Page MenuHomeFreeBSD
Differential D16959

Don't load ccp automatically.
ClosedPublic
Actions

Authored by imp on Aug 30 2018, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 5:58 PM
Unknown Object (File)
Sat, Sep 26, 11:09 AM
Unknown Object (File)
Sat, Sep 19, 7:14 AM
Unknown Object (File)
Sat, Sep 19, 7:12 AM
Unknown Object (File)
Sun, Sep 13, 5:35 PM
Unknown Object (File)
Sat, Sep 12, 2:26 PM
Unknown Object (File)
Sat, Sep 12, 1:17 PM
Unknown Object (File)
Thu, Sep 10, 1:48 PM
View All 92 Files
Subscribers
None

Details

Reviewers
jhb
cem
Summary

Remove the PNP info for the moment from the driver. There's a number
of known issues with this, including that the performance isn't very
good even when everything is working well.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19298
Build 18906: arc lint + arc unit

Event Timeline

imp created this revision.Aug 30 2018, 9:00 PM
Harbormaster completed remote builds in B19298: Diff 47498.Aug 30 2018, 9:00 PM
imp added reviewers: jhb, cem.Aug 30 2018, 9:14 PM
cem accepted this revision.Aug 30 2018, 9:33 PM

LGTM, thanks.

This revision is now accepted and ready to land.Aug 30 2018, 9:33 PM
cem added a comment.EditedAug 30 2018, 10:12 PM

To provide some context in case anyone is curious:

Here's the known bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227982

And here's some notes on the performance relative to AESNI (available on the same hardware), from original commit: https://svnweb.freebsd.org/base?view=revision&revision=r328150

imp added a comment.Aug 30 2018, 10:38 PM

Thanks for the context, I'll update the commit message and submit to re@

imp closed this revision.EditedAug 31 2018, 1:05 AM

rS338402 fixes this. Said differential review, not differential revision.

Revision Contents
Changeset List

PathSize
sys/
crypto/
ccp/
2 lines

Diff 47498

View Options

sys/crypto/ccp/ccp.c

Loading...