Page MenuHomeFreeBSD

Remove 'imen' global variable from atpic(4).
ClosedPublic

Authored by jhb on Aug 21 2018, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 19, 8:54 AM
Unknown Object (File)
Sun, Jan 19, 8:54 AM
Unknown Object (File)
Sun, Jan 19, 8:54 AM
Unknown Object (File)
Sun, Jan 19, 8:54 AM
Unknown Object (File)
Sun, Jan 19, 5:14 AM
Unknown Object (File)
Thu, Jan 16, 9:09 PM
Unknown Object (File)
Thu, Jan 16, 1:11 AM
Unknown Object (File)
Dec 25 2024, 4:02 PM
Subscribers

Details

Summary

In pre-SMPng, the global 'imen' was used to track mask state of the
hardware interrupts and was aligned to the masks used by spl*().
When the atpic code was converted to using the x86 interrupt source
abstraction, the global 'imen' was preserved by having each PIC
instance point to an invididual byte in the global 'imen' to hold its
8-bit interrupt mask. The global 'imen' is no longer used for
anything however, so rather than storing pointers in 'struct atpic',
just store the individual 8-bit mask for each PIC as a char.

While here, convert the ATPIC macro to using C99 initializers.

Test Plan
  • booted an i386 kernel with hint.apic.0.disabled under bhyve.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable