Page MenuHomeFreeBSD

Remove 'imen' global variable from atpic(4).
ClosedPublic

Authored by jhb on Aug 21 2018, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 1, 2:39 AM
Unknown Object (File)
Sep 7 2025, 6:33 PM
Unknown Object (File)
Jul 25 2025, 4:32 AM
Unknown Object (File)
Jun 27 2025, 12:59 PM
Unknown Object (File)
Jun 25 2025, 1:49 AM
Unknown Object (File)
Jun 23 2025, 10:19 PM
Unknown Object (File)
Jun 22 2025, 7:27 AM
Unknown Object (File)
Jun 19 2025, 4:40 PM
Subscribers

Details

Summary

In pre-SMPng, the global 'imen' was used to track mask state of the
hardware interrupts and was aligned to the masks used by spl*().
When the atpic code was converted to using the x86 interrupt source
abstraction, the global 'imen' was preserved by having each PIC
instance point to an invididual byte in the global 'imen' to hold its
8-bit interrupt mask. The global 'imen' is no longer used for
anything however, so rather than storing pointers in 'struct atpic',
just store the individual 8-bit mask for each PIC as a char.

While here, convert the ATPIC macro to using C99 initializers.

Test Plan
  • booted an i386 kernel with hint.apic.0.disabled under bhyve.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable