sys/types.h: avoid using terse macro _M
ClosedPublic
Actions

Authored by emaste on Aug 15 2018, 9:43 PM.

Tags

None

Referenced Files

	F158422231: D16734.id.diff
	Mon, Jun 1, 9:49 AM

	Unknown Object (File)
	Sun, May 31, 3:08 PM

	Unknown Object (File)
	Sun, May 31, 6:09 AM

	Unknown Object (File)
	Fri, May 29, 10:08 AM

	Unknown Object (File)
	Sat, May 23, 4:35 PM

	Unknown Object (File)
	Mon, May 18, 2:54 PM

	Unknown Object (File)
	Sun, May 17, 5:19 PM

	Unknown Object (File)
	Sat, May 16, 9:24 AM

View All 76 Files

Subscribers

imp

Details

Reviewers

dim

Commits

rS340079: sys/types.h: avoid using terse macro _M

Summary

Although _M is reserved for use by the implementation it is rather non-descriptive and conflicted with a libc++ test. Just rename to _Major and _Minor to avoid conflicts.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Aug 15 2018, 9:43 PM

LGTM, maybe also rename the arguments of the preceding macro, for consistency?

This revision is now accepted and ready to land.Aug 16 2018, 5:10 AM

Closed by commit rS340079: sys/types.h: avoid using terse macro _M (authored by emaste). · Explain WhyNov 2 2018, 8:48 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 2 2018, 8:48 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

types.h

6 lines

Diff 49955

View Options

sys/types.h: avoid using terse macro _MClosedPublicActions