Page MenuHomeFreeBSD

Apply latest wpa security patch to net/hostapd
ClosedPublic

Authored by cy on Aug 15 2018, 12:26 PM.

Details

Summary

Though net/hostapd is not specifically affected by the Unauthenticated EAPOL-Key Decryption Vulnerability, the patch does apply. This revision applies the patch.

Test Plan

make check-orphans package passed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cy created this revision.Aug 15 2018, 12:26 PM
mat added inline comments.Aug 15 2018, 12:40 PM
net/hostapd/Makefile
18 ↗(On Diff #46701)

That patch is only available on the 2018 URL, and all the other are only available on the 2017 one. So this is wrong.

net/hostapd/distinfo
16–17 ↗(On Diff #46701)

This patch is not present in the Makefile, how did it end up here?

cy marked 2 inline comments as done.Aug 15 2018, 7:27 PM
cy added inline comments.
net/hostapd/Makefile
18 ↗(On Diff #46701)

Reworked. I make the same change to security/wpa_supplicant.

net/hostapd/distinfo
16–17 ↗(On Diff #46701)

Ahh yes, previous distinfo for a file not needed. It's been removed.

cy updated this revision to Diff 46730.Aug 15 2018, 7:28 PM
cy marked 2 inline comments as done.

Changed patch sites to parent directory; specified dir name in patchfiles.

leres accepted this revision.Aug 16 2018, 12:39 AM

If you add a blank line before PATCH_SITES the Makefile will pass portlint. Otherwise looks good to me.

Also feel free to assume maintainership as discussed offline.

This revision is now accepted and ready to land.Aug 16 2018, 12:39 AM
mat added inline comments.Aug 16 2018, 2:41 PM
net/hostapd/Makefile
18 ↗(On Diff #46701)

Ok, this was one way to do it, maybe more convoluted than necessary, you could also have used groups.

cy added a comment.Aug 16 2018, 9:01 PM

Gotcha. I'll use groups instead. Thanks for the input Mat.