Page MenuHomeFreeBSD
Differential D16718

Apply latest wpa security patch to net/hostapd
ClosedPublic
Actions

Authored by cy on Aug 15 2018, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 5:01 PM
Unknown Object (File)
Nov 25 2024, 5:40 AM
Unknown Object (File)
Nov 24 2024, 5:39 PM
Unknown Object (File)
Nov 19 2024, 7:32 AM
Unknown Object (File)
Nov 8 2024, 1:29 AM
Unknown Object (File)
Oct 15 2024, 9:12 PM
Unknown Object (File)
Oct 15 2024, 11:18 AM
Unknown Object (File)
Oct 15 2024, 11:18 AM
View All Files
Subscribers
mat

Details

Reviewers
leres
Commits
rP477445: MFH: r477402 r477403
rP477403: Chase net/wpa_supplicant r477202 and base contrib/wpa r337819.
rP477402: In preparation for applying security patches, switch to grouping of
Summary

Though net/hostapd is not specifically affected by the Unauthenticated EAPOL-Key Decryption Vulnerability, the patch does apply. This revision applies the patch.

Test Plan

make check-orphans package passed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cy created this revision.Aug 15 2018, 12:26 PM
Herald added a subscriber: mat. · View Herald TranscriptAug 15 2018, 12:26 PM
mat added inline comments.Aug 15 2018, 12:40 PM
net/hostapd/Makefile
18 ↗(On Diff #46701)

That patch is only available on the 2018 URL, and all the other are only available on the 2017 one. So this is wrong.

net/hostapd/distinfo
16–17 ↗(On Diff #46701)

This patch is not present in the Makefile, how did it end up here?

cy marked 2 inline comments as done.Aug 15 2018, 7:27 PM
cy added inline comments.
net/hostapd/Makefile
18 ↗(On Diff #46701)

Reworked. I make the same change to security/wpa_supplicant.

net/hostapd/distinfo
16–17 ↗(On Diff #46701)

Ahh yes, previous distinfo for a file not needed. It's been removed.

cy updated this revision to Diff 46730.Aug 15 2018, 7:28 PM
cy marked 2 inline comments as done.

Changed patch sites to parent directory; specified dir name in patchfiles.

leres accepted this revision.Aug 16 2018, 12:39 AM

If you add a blank line before PATCH_SITES the Makefile will pass portlint. Otherwise looks good to me.

Also feel free to assume maintainership as discussed offline.

This revision is now accepted and ready to land.Aug 16 2018, 12:39 AM
mat added inline comments.Aug 16 2018, 2:41 PM
net/hostapd/Makefile
18 ↗(On Diff #46701)

Ok, this was one way to do it, maybe more convoluted than necessary, you could also have used groups.

cy added a comment.Aug 16 2018, 9:01 PM

Gotcha. I'll use groups instead. Thanks for the input Mat.

Closed by commit rP477402: In preparation for applying security patches, switch to grouping of (authored by cy). · Explain WhyAug 17 2018, 2:12 AM
This revision was automatically updated to reflect the committed changes.
cy mentioned this in rP477401: Switch to grouping of patches per site as suggested by mat@ in D16718..
cy mentioned this in rP477404: leres@ suggested in D16718 and offline that I assume maintainership.

Revision Contents
Changeset List

PathSize
head/
net/
hostapd/
16 lines

Diff 46813

View Options

head/net/hostapd/Makefile

Loading...