contrib/lua: Hack around overflow issues
AbandonedPublic
Actions

Authored by kevans on Aug 13 2018, 3:49 PM.

Details

Reviewers

Summary

These hacks will go away when we can update to 5.4, after its release. GCC 4.2 on 64-bit archs fails for these -cast_num(LUA_MININTEGER) bits, despite them being likely harmless and definitely intentional.

Since these functions are for float comparisons anyways, and our float is actually an integer, this should still be effectively a nop.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 18769

Event Timeline

kevans created this revision.Aug 13 2018, 3:49 PM

Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptAug 13 2018, 3:49 PM

Harbormaster completed remote builds in B18769: Diff 46625.Aug 13 2018, 3:49 PM

kevans added inline comments.Aug 13 2018, 3:50 PM

stand/liblua/luaconf.h
453	jhibbits points out that I likely wanted another level of parentheses here... this can be fixed before commit, depending on how we want to go about this.

I think that https://reviews.freebsd.org/P206 addresses the 'bogus' issues, as well as fixing some new whines that my mips build is showing.
Comments?

contrib/lua/src/lvm.c
282	I think this is bogus.
305	Ditto.
stand/liblua/luaconf.h
453	I think it's fine as is, but I'm not fussy.

@imp addressed separately.

Revision Contents
Changeset List

Path

Size

contrib/

lua/

src/

lvm.c

9 lines

stand/

liblua/

luaconf.h

4 lines

Diff 46625

View Options

contrib/lua/src/lvm.c