Make ldconfig(8) atomic
ClosedPublic
Actions

Authored by trasz on Aug 9 2018, 11:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 1, 10:43 PM

	Unknown Object (File)
	Mon, Dec 1, 3:25 AM

	Unknown Object (File)
	Fri, Nov 28, 6:13 PM

	Unknown Object (File)
	Fri, Nov 28, 6:41 AM

	Unknown Object (File)
	Wed, Nov 26, 6:50 PM

	Unknown Object (File)
	Wed, Nov 26, 6:24 AM

	Unknown Object (File)
	Mon, Nov 24, 3:15 PM

	Unknown Object (File)
	Sat, Nov 22, 7:42 AM

View All Files

Subscribers

imp

Details

Reviewers

imp
kib

Commits

rS337530: Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2)

Summary

Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2)
before rename(2).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Aug 9 2018, 11:13 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 9 2018, 11:13 AM

Harbormaster completed remote builds in B18662: Diff 46455.Aug 9 2018, 11:13 AM

trasz added reviewers: imp, kib.Aug 9 2018, 11:14 AM

Spurious empty line.

Harbormaster completed remote builds in B18663: Diff 46456.Aug 9 2018, 11:15 AM

kib accepted this revision.Aug 9 2018, 11:24 AM

This revision is now accepted and ready to land.Aug 9 2018, 11:24 AM

kib added inline comments.Aug 9 2018, 11:26 AM

sbin/ldconfig/ldconfig.c
522 ↗	(On Diff #46456)	This comment really marks both unlink() and rename() calls and could be preserved. It is arguably not too useful.

Closed by commit rS337530: Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2) (authored by trasz). · Explain WhyAug 9 2018, 11:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

ldconfig/

ldconfig.c

7 lines

Diff 46458

View Options

head/sbin/ldconfig/ldconfig.c

Make ldconfig(8) atomicClosedPublicActions