Page MenuHomeFreeBSD
Differential D16641

Make ldconfig(8) atomic
ClosedPublic
Actions

Authored by trasz on Aug 9 2018, 11:13 AM.
Tags
None
Referenced Files
F151638571: D16641.id.diff
Thu, Apr 9, 4:57 PM
Unknown Object (File)
Mon, Apr 6, 5:24 AM
Unknown Object (File)
Fri, Apr 3, 8:03 PM
Unknown Object (File)
Sun, Mar 29, 4:18 PM
Unknown Object (File)
Sun, Mar 29, 12:05 PM
Unknown Object (File)
Sun, Mar 29, 9:51 AM
Unknown Object (File)
Sun, Mar 29, 2:49 AM
Unknown Object (File)
Thu, Mar 26, 1:09 PM
View All Files
Subscribers
imp

Details

Reviewers
imp
kib
Commits
rS337530: Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2)
Summary

Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2)
before rename(2).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Aug 9 2018, 11:13 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 9 2018, 11:13 AM
Harbormaster completed remote builds in B18662: Diff 46455.Aug 9 2018, 11:13 AM
trasz added reviewers: imp, kib.Aug 9 2018, 11:14 AM
trasz updated this revision to Diff 46456.Aug 9 2018, 11:15 AM

Spurious empty line.

Harbormaster completed remote builds in B18663: Diff 46456.Aug 9 2018, 11:15 AM
kib accepted this revision.Aug 9 2018, 11:24 AM
This revision is now accepted and ready to land.Aug 9 2018, 11:24 AM
kib added inline comments.Aug 9 2018, 11:26 AM
sbin/ldconfig/ldconfig.c
522 ↗(On Diff #46456)

This comment really marks both unlink() and rename() calls and could be preserved. It is arguably not too useful.

Closed by commit rS337530: Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2) (authored by trasz). · Explain WhyAug 9 2018, 11:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
ldconfig/
7 lines

Diff 46458

View Options

head/sbin/ldconfig/ldconfig.c

Loading...