Remove spurious ABI tags from kdump output.

[jhb]

Summary

The abidump routine output an ABI tag when -A was specified for records
that were not displayed due to type or pid filtering. To fix, split
the code to lookup the ABI from the code to display the ABI, move the
code to display the ABI into dumpheader(), and move dumpheader() later
in the main loop as a simplification. Previously dumpheader() was
called under a condition that repeated conditions made later in the
main loop.

Test Plan

• ktrace ls
• kdump -A -t n ls

[kib]

usr.bin/kdump/kdump.c

697 ↗

(On Diff #46346)

if (abiflag != 0) {

713 ↗

(On Diff #46346)

!= 0 as well.

718 ↗

(On Diff #46346)

BTW, is this for alignment ? Would it better to print to spaces instead ?

[jhb]

usr.bin/kdump/kdump.c

697 ↗

(On Diff #46346)

The rest of this function uses the current style. I could make it a bool as a followup perhaps. For tests that are in fact booleans the != 0 seems overly verbose.

718 ↗

(On Diff #46346)

Possibly, or '??'