Page MenuHomeFreeBSD

Fix casts between 64-bit physical addresses and pointers in EFI.
ClosedPublic

Authored by jhb on Aug 3 2018, 9:00 PM.

Details

Summary

Compiling FreeBSD/i386 with modern GCC triggers warnings for various
places that convert 64-bit EFI_ADDRs to pointers and vice versa.

  • Cast pointers to uintptr_t rather than to uint64_t when assigning to a 64-bit integer.
  • Cast 64-bit integers to uintptr_t before a cast to a pointer.
Test Plan
  • build world with CROSS_TOOLCHAIN=i386-gcc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Aug 14 2018, 4:23 AM
This revision was automatically updated to reflect the committed changes.