Page MenuHomeFreeBSD
Differential D16551

devel/powerpc64-gcc: Remove a spurious $ introduced in r475290.
ClosedPublic
Actions

Authored by jhb on Aug 1 2018, 8:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 5:08 PM
Unknown Object (File)
Sun, Oct 12, 6:50 AM
Unknown Object (File)
Sat, Oct 11, 9:51 AM
Unknown Object (File)
Mon, Oct 6, 3:43 AM
Unknown Object (File)
Fri, Oct 3, 3:49 AM
Unknown Object (File)
Thu, Oct 2, 5:02 AM
Unknown Object (File)
Tue, Sep 30, 5:03 AM
Unknown Object (File)
Sat, Sep 27, 1:24 AM
View All Files
Subscribers
mat

Details

Reviewers
kan
mat
Commits
rP476273: Remove a spurious $ introduced in r475290.
Summary

Reported by: Mark Millard

This appears to have been harmless as the port worked regardless.

Test Plan
  • poudriere testport of amd64-gcc and i386-gcc

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Aug 1 2018, 8:17 PM
Herald added a subscriber: mat. · View Herald TranscriptAug 1 2018, 8:17 PM
Harbormaster completed remote builds in B18498: Diff 46151.Aug 1 2018, 8:17 PM
mat accepted this revision.Aug 2 2018, 9:07 AM

If all you need is a committer's approval, please go ahead.

This revision is now accepted and ready to land.Aug 2 2018, 9:07 AM
linimon retitled this revision from Remove a spurious $ introduced in r475290. to devel/powerpc64-gcc: Remove a spurious $ introduced in r475290..Aug 2 2018, 9:47 PM
kan accepted this revision.Aug 2 2018, 10:55 PM

..

kan added a comment.Aug 2 2018, 10:57 PM

For the record, you do not need approval for typo fix in your own revision.

Closed by commit rP476273: Remove a spurious $ introduced in r475290. (authored by jhb). · Explain WhyAug 2 2018, 11:56 PM
This revision was automatically updated to reflect the committed changes.
jhb added a comment.Aug 2 2018, 11:57 PM
In D16551#351910, @kan wrote:

For the record, you do not need approval for typo fix in your own revision.

Thanks. I am perhaps a tad overly cautious about ports. bapt@ has given me a blanket approval for base/* for now, but I'd rather run any non-trivial changes to devel/*gcc by you.

Revision Contents
Changeset List

PathSize
head/
devel/
powerpc64-gcc/
2 lines

Diff 46221

View Options

head/devel/powerpc64-gcc/Makefile

Loading...