Page MenuHomeFreeBSD

Xen: Make gnttab_list_lock a recursive lock
ClosedPublic

Authored by pratyush on Jul 30 2018, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 1:11 AM
Unknown Object (File)
Wed, Jun 3, 10:42 PM
Unknown Object (File)
Wed, Jun 3, 9:13 PM
Unknown Object (File)
Sun, May 31, 5:39 AM
Unknown Object (File)
May 8 2026, 1:50 AM
Unknown Object (File)
May 5 2026, 10:01 PM
Unknown Object (File)
Apr 24 2026, 10:02 PM
Unknown Object (File)
Apr 21 2026, 11:31 AM
Subscribers

Details

Summary

This fixes the panic caused by lock recursion when the grant-table free callbacks are used.

The cause of the recursion is: check_free_callbacks() is always called with the lock gnttab_list_lock held. So, the callback function is called with the lock held. So, when the client uses any of the grant reference allocation methods get_free_entries() is called, which tries to acquire gnttab_list_lock, causing a recursion on the non-recursive lock.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 30 2018, 11:36 AM
This revision was automatically updated to reflect the committed changes.