Page MenuHomeFreeBSD

Xen: Make gnttab_list_lock a recursive lock
ClosedPublic

Authored by pratyush on Jul 30 2018, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 9 2024, 3:44 PM
Unknown Object (File)
Dec 9 2024, 3:40 PM
Unknown Object (File)
Dec 6 2024, 6:53 PM
Unknown Object (File)
Nov 27 2024, 12:06 AM
Unknown Object (File)
Nov 14 2024, 1:04 AM
Unknown Object (File)
Oct 17 2024, 1:30 AM
Unknown Object (File)
Sep 30 2024, 5:12 PM
Unknown Object (File)
Sep 25 2024, 3:41 PM
Subscribers

Details

Summary

This fixes the panic caused by lock recursion when the grant-table free callbacks are used.

The cause of the recursion is: check_free_callbacks() is always called with the lock gnttab_list_lock held. So, the callback function is called with the lock held. So, when the client uses any of the grant reference allocation methods get_free_entries() is called, which tries to acquire gnttab_list_lock, causing a recursion on the non-recursive lock.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 30 2018, 11:36 AM
This revision was automatically updated to reflect the committed changes.