Details
- Reviewers
- None
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 18530 Build 18232: arc lint + arc unit
Event Timeline
misc/paperwork/Makefile | ||
---|---|---|
18–19 | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. | |
23–24 | This is most likely wrong, I do not think gitlab account names can have / in them. Also, as https://gitlab.gnome.org is not a gitlab instance, this should probably be: GL_SITE= https://gitlab.gnome.org/World GL_ACCOUNT= OpenPaperwork | |
28–47 | Please use flavor helpers, also, wrong place in the Makefile. |
I think you need to add a description of the flavors in pkg-descr. Or even better, provide two pkg-descr files, one for each flavor, with a description of what part of the software they correspond to, exactly.
misc/paperwork/Makefile | ||
---|---|---|
28–47 | Not sure how to use helpers for these. Helpers aren't defined for PATCHDIR and WRKSRC_SUBDIR. |
misc/paperwork/Makefile | ||
---|---|---|
28–47 | Not sure what you mean. The lines this refers to are the depends lines. Which you can see by clicking on the '<<' arrow meaning "this comment refers to a previous diff". You should also use helpers for DESCR and PKGNAMESUFFIX. |
misc/paperwork/Makefile | ||
---|---|---|
28–47 | I added helpers for DESCR and PKGNAMESUFFIX. |
misc/paperwork/Makefile | ||
---|---|---|
28–47 | PATCHDIR doesn't work as a helper. |
misc/paperwork/Makefile | ||
---|---|---|
28–47 | Good, good, wondering if you are being obtuse on purpose or not. |
misc/paperwork/Makefile | ||
---|---|---|
28–47 |
I was wondering this way about you after every other message from you. |