New port: misc/paperwork: Need portmgr approval for flavors

[yuri]

.

[mat]

misc/paperwork/Makefile

18–19

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

23–24

This is most likely wrong, I do not think gitlab account names can have / in them.

Also, as https://gitlab.gnome.org is not a gitlab instance, this should probably be:

GL_SITE=        https://gitlab.gnome.org/World
​GL_ACCOUNT=     OpenPaperwork

28–47

Please use flavor helpers, also, wrong place in the Makefile.

[yuri]

.

[yuri]

Fixed GL_xx tags.

[mat]

I think you need to add a description of the flavors in pkg-descr. Or even better, provide two pkg-descr files, one for each flavor, with a description of what part of the software they correspond to, exactly.

[yuri]

Add separate pkg-descr for each flavor.

[yuri]

.

[yuri]

misc/paperwork/Makefile

28–47

Not sure how to use helpers for these. Helpers aren't defined for PATCHDIR and WRKSRC_SUBDIR.

[mat]

misc/paperwork/Makefile

28–47

Not sure what you mean. The lines this refers to are the depends lines.

Which you can see by clicking on the '<<' arrow meaning "this comment refers to a previous diff".

You should also use helpers for DESCR and PKGNAMESUFFIX.

[yuri]

.

[yuri]

misc/paperwork/Makefile

28–47

I added helpers for DESCR and PKGNAMESUFFIX.

[yuri]

misc/paperwork/Makefile

28–47

PATCHDIR doesn't work as a helper.

[mat]

misc/paperwork/Makefile

28–47

Good, good, wondering if you are being obtuse on purpose or not.
Now, all you have to do is use helpers for the RUN_DEPENDS.

[yuri]

misc/paperwork/Makefile

28–47

Good, good, wondering if you are being obtuse on purpose or not.

I was wondering this way about you after every other message from you.

[yuri]

.