comms/py-esptool: Utility to communicate with Espressif ESP8266 & ESP32 chips
ClosedPublic
Actions

Authored by loader on Jul 28 2018, 3:30 PM.

Details

Reviewers

koobs

Commits

rP475970: [NEW PORT] comms/py-esptool: Utility to communicate with Espressif ESP8266 &…

Summary

Proposed commit log message:

[NEW PORT] comms/py-esptool: Utility to communicate with Espressif ESP8266 & ESP32 chips

A Python-based, open source, platform independent, utility to communicate
with the ROM bootloader in Espressif ESP8266 & ESP32 chips.

WWW: https://github.com/espressif/esptool

Reviewed_by: koobs, mat
Approved by: koobs (mentor)
Differential_Revision: D16483

Test Plan

portlint: OK (

WARN: Makefile: possible use of absolute pathname "/dev/ttyU0".
0 fatal errors and 1 warning found.
)

testport: OK (poudriere: 1200072, [armv7, aarch64], 'BUILD_ALL_PYTHON_FLAVORS=1', [py27, py34, py35, py36, py37] tested)
unittest: OK (

Tested ESP8266 with CP2102 USB serial adapter on Raspberry Pi 3B (aarch64)
Python2.7: pytest: 56 passed, test_esptool.py: 41 passed
Python3.4: pytest: 56 passed, test_esptool.py: 40 passed 1 failed
Python3.5: pytest: 56 passed, test_esptool.py: 40 passed 1 failed
Python3.6: pytest: 56 passed, test_esptool.py: 40 passed 1 failed
Python3.7: pytest: 56 passed, test_esptool.py: 40 passed 1 failed
)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 18427
Build 18135: arc lint + arc unit

Event Timeline

loader created this revision.Jul 28 2018, 3:30 PM

Herald added a subscriber: mat. · View Herald TranscriptJul 28 2018, 3:30 PM

Harbormaster completed remote builds in B18394: Diff 45952.Jul 28 2018, 3:30 PM

loader edited the summary of this revision. (Show Details)Jul 28 2018, 3:32 PM

mat added inline comments.Jul 30 2018, 10:00 AM

comms/py-esptool/Makefile
5	When its usage is not needed, try to use DISTVERSION and not PORTVERSION.

PORTVERSION => DISTVERSION

Harbormaster completed remote builds in B18427: Diff 46016.Jul 30 2018, 1:31 PM

loader edited the summary of this revision. (Show Details)Jul 30 2018, 1:34 PM

loader marked an inline comment as done.

loader added inline comments.

comms/py-esptool/Makefile
5	Sure, thanks @mat.

koobs edited the summary of this revision. (Show Details)Jul 31 2018, 4:16 AM

Use MASTER_SITES=CHEESESHOP by default for Python package distribution files when the source distribution (sdist) is published there (as this one is), unless there is a compelling temporary case to use an alternative source location (like GitHub); such as missing test files / important data files, etc. In these cases, ask upstream to include relevant files in the sdist

Approved if GitHub sources are needed, otherwise please update to CHEESESHOP if not.

This revision is now accepted and ready to land.Jul 31 2018, 4:20 AM

In D16483#350723, @koobs wrote:

Use MASTER_SITES=CHEESESHOP by default for Python package distribution files when the source distribution (sdist) is published there (as this one is), unless there is a compelling temporary case to use an alternative source location (like GitHub); such as missing test files / important data files, etc.

The sdist published on CHEESESHOP doesn't include the test/ directory.