Update security/suricata to 4.0.5

[garga]

Summary

Update security/suricata to 4.0.5

Security: CVE-2018-10242, CVE-2018-10244
MFH: 2018Q3
Obtained from: pfSense
Sponsored by: Rubicon Communications, LLC (Netgate)

[franco_opnsense.org]

There's a PR here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229904

[garga]

In D16366#348279, @franco_opnsense.org wrote:

There's a PR here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229904

I just sent the review because at that time the PR was not opened yet. Note that it was opened 40 minutes after the review. I believe since it fixes 2 CVEs the most important for users is to get it committed ASAP.

[franco_opnsense.org]

I'm sorry, I'm playing by the rules that FreeBSD imposes on its external contributors.

[garga]

Submitting a review here on phabricator is completely fine when maintainer is active here. as I knew you are before send it. I just considered the fastest path to get the port updated. If you approved it here we could have it upgraded without any problems and users would be glad to have the new version available.

[franco_opnsense.org]

I do not wish to acknowledge the advertising in the commit message.

[garga]

I used to add the Sponsored by: as many others because I'm paid to work on it. But users always come first and I'm here with my FreeBSD ports hat. I can commit it using a personal time to make you happier. I'll not use Obtained from nor Sponsored by lines. Are you OK with that?

[franco_opnsense.org]

We all invest time so thank you for the offer. Yes, I am OK with that.