Page MenuHomeFreeBSD

Set a mode when calling open with O_CREAT
AcceptedPublic

Authored by andrew on Jul 19 2018, 3:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 30 2024, 11:59 PM
Unknown Object (File)
Jan 1 2024, 1:45 AM
Unknown Object (File)
Nov 14 2023, 5:15 AM
Unknown Object (File)
Aug 25 2023, 10:04 PM
Unknown Object (File)
Aug 2 2023, 6:07 PM
Unknown Object (File)
Jul 15 2023, 10:06 PM
Unknown Object (File)
Jun 27 2023, 2:57 PM
Unknown Object (File)
May 5 2023, 8:06 PM
Subscribers
None

Details

Reviewers
brooks
ngie
Summary

We shouldn't be creating files without also setting the mode, otherwise
the kernel will use whatever value is in the third argument location.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18168
Build 17902: arc lint + arc unit

Event Timeline

LGTM. I'd commit the netbsd ones separately and forward the commit some appropriate netbsd list (probably tech-kern).

This revision is now accepted and ready to land.Jul 19 2018, 11:17 PM

@brooks: LGTM. I'd commit the netbsd ones separately and forward the commit some appropriate netbsd list (probably tech-kern).

I can handle creating the PRs on their end for this. Just need to create a NetBSD VM, checkout the sources, etc :) (since I deleted it a while ago).