Page MenuHomeFreeBSD

math/stp: Update to latest version 2.3.1.
ClosedPublic

Authored by arrowd on Jul 16 2018, 9:53 AM.

Details

Summary

I've changed PORTVERSION from revision number to the correct one. How do I verify it doesn't go backwards for pkg and other tools?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arrowd created this revision.Jul 16 2018, 9:53 AM
lwhsu added a subscriber: lwhsu.Jul 16 2018, 4:56 PM
$ pkg version -t 1436 2.3.1
>

So I am afraid that we need PORTEPOCH here. It was my fault that time...

You can find the documentation here.

arrowd updated this revision to Diff 45381.Jul 16 2018, 6:00 PM
  • Add PORTEPOCH and move USE_GITHUB into the right place.
tcberner added inline comments.Jul 16 2018, 6:20 PM
math/stp/Makefile
16 ↗(On Diff #45381)

^ is it working now?

19 ↗(On Diff #45381)

^ could you check whether cmake:outsource works?

arrowd added inline comments.Jul 16 2018, 6:42 PM
math/stp/Makefile
16 ↗(On Diff #45381)

No idea. But how do we know?

tcberner added inline comments.Jul 16 2018, 6:46 PM
math/stp/Makefile
16 ↗(On Diff #45381)

Hehe, I think in that case I would leave it in.

arrowd updated this revision to Diff 45488.Jul 18 2018, 6:11 PM
  • Address comments.
arrowd marked 2 inline comments as done.Jul 18 2018, 6:11 PM
tcberner accepted this revision.Jul 18 2018, 6:23 PM

with the mentioned change, it looks fine.

math/stp/Makefile
16 ↗(On Diff #45488)

^ please use a tab after "=" not a simple whitespace.

This revision is now accepted and ready to land.Jul 18 2018, 6:23 PM
This revision was automatically updated to reflect the committed changes.