Page MenuHomeFreeBSD

Skip the use of lxqt-l10n as master port for lxqt related l10n ports.
ClosedPublic

Authored by jsm on Jul 8 2018, 9:02 PM.

Details

Summary

Do not use x11/lxqt-l10n as master port, fix install path of qtermwidget-l10n

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jsm created this revision.Jul 8 2018, 9:02 PM
swills added a comment.Jul 8 2018, 9:14 PM

Does it pass portlint? Have you run it through poudriere?

Should have mentioned, you want portlint -C

swills added a comment.Jul 9 2018, 2:35 AM
In D16185#343205, @jsm wrote:

Great, thanks. Like portlint fix the DATADIR things if you can. If you can't, no problem. Also, can you post your proposed commit message? Thanks!

jsm added a comment.Jul 9 2018, 4:34 AM

I do not think you can override datadir for qterminal and qterminal-l10n . My commit message would be:

Do not use x11/lxqt-l10n as a  master port. Fix install path of qtermwidget-l10n.

Fixes portlint fatal errors about wrongly used masterdir. 
Only functional change is in qtermwidget-l10n.

And i would list the PR 229413 229414 229417 229418 229419 229421.

swills added a comment.Jul 9 2018, 5:34 AM
In D16185#343301, @jsm wrote:

I do not think you can override datadir for qterminal and qterminal-l10n .

Ok, that's fine.

My commit message would be:

Do not use x11/lxqt-l10n as a  master port. Fix install path of qtermwidget-l10n.
Fixes portlint fatal errors about wrongly used masterdir. 
Only functional change is in qtermwidget-l10n.

And i would list the PR 229413 229414 229417 229418 229419 229421.

You would need to list each PR on a separate line and you need to mention the mentor approval as well.

jsm added a comment.Jul 9 2018, 8:29 AM

And i would list the PR 229413 229414 229417 229418 229419 229421.

You would need to list each PR on a separate line and you need to mention the mentor approval as well.

Sure, but 7. Commit Log Messages
states:
Multiple PRs may be specified on one line, separated by commas or spaces is that wrong?
And should it be:
PR: #DDDD
PR: #DDDD
or PR:#DDDD
#DDDD

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2018, 4:40 PM
This revision was automatically updated to reflect the committed changes.