Do not use x11/lxqt-l10n as master port, fix install path of qtermwidget-l10n
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
poudriere logs here https://people.freebsd.org/~jsm/build.html.
portlint -C has warnings:
https://people.freebsd.org/~jsm/portlint.txt
Great, thanks. Like portlint fix the DATADIR things if you can. If you can't, no problem. Also, can you post your proposed commit message? Thanks!
I do not think you can override datadir for qterminal and qterminal-l10n . My commit message would be:
Do not use x11/lxqt-l10n as a master port. Fix install path of qtermwidget-l10n. Fixes portlint fatal errors about wrongly used masterdir. Only functional change is in qtermwidget-l10n.
And i would list the PR 229413 229414 229417 229418 229419 229421.
Ok, that's fine.
My commit message would be:
Do not use x11/lxqt-l10n as a master port. Fix install path of qtermwidget-l10n. Fixes portlint fatal errors about wrongly used masterdir. Only functional change is in qtermwidget-l10n.And i would list the PR 229413 229414 229417 229418 229419 229421.
You would need to list each PR on a separate line and you need to mention the mentor approval as well.
And i would list the PR 229413 229414 229417 229418 229419 229421.
You would need to list each PR on a separate line and you need to mention the mentor approval as well.
Sure, but 7. Commit Log Messages
states:
Multiple PRs may be specified on one line, separated by commas or spaces is that wrong?
And should it be:
PR: #DDDD
PR: #DDDD
or PR:#DDDD
#DDDD