Page MenuHomeFreeBSD

devel/avarice: unbreak build under 11.2-RELEASE (and clang 6)
ClosedPublic

Authored by leres on Jul 8 2018, 8:57 PM.

Details

Summary

Proposed commit message:

After upgrading to 11.2-RELEASE devel/avarice fails to
compile with:

jtagrw.cc:134:13: error: cannot initialize return object of type 'uchar *' (aka 'unsigned char *') with an rvalue of type 'bool'

            return false;
                   ^~~~~

examination of the code shows another case with a similar
check that returns NULL.

I also filed an upstream bug report:

https://sourceforge.net/p/avarice/bugs/24/

PR: 229376
Reviewed by: ? (mentor)
Approved by: joerg (maintainer), ? (mentor)
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.