Page MenuHomeFreeBSD

devel/avarice: unbreak build under 11.2-RELEASE (and clang 6)
ClosedPublic

Authored by leres on Jul 8 2018, 8:57 PM.
Tags
None
Referenced Files
F132518454: D16184.id45032.diff
Fri, Oct 17, 2:45 PM
Unknown Object (File)
Tue, Oct 14, 4:12 AM
Unknown Object (File)
Tue, Oct 14, 1:52 AM
Unknown Object (File)
Thu, Sep 25, 5:08 AM
Unknown Object (File)
Wed, Sep 24, 1:49 AM
Unknown Object (File)
Wed, Sep 24, 1:18 AM
Unknown Object (File)
Tue, Sep 23, 4:48 PM
Unknown Object (File)
Tue, Sep 23, 3:40 AM
Subscribers

Details

Summary

Proposed commit message:

After upgrading to 11.2-RELEASE devel/avarice fails to
compile with:

jtagrw.cc:134:13: error: cannot initialize return object of type 'uchar *' (aka 'unsigned char *') with an rvalue of type 'bool'

            return false;
                   ^~~~~

examination of the code shows another case with a similar
check that returns NULL.

I also filed an upstream bug report:

https://sourceforge.net/p/avarice/bugs/24/

PR: 229376
Reviewed by: ? (mentor)
Approved by: joerg (maintainer), ? (mentor)
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable