Page MenuHomeFreeBSD

devel/avarice: unbreak build under 11.2-RELEASE (and clang 6)
ClosedPublic

Authored by leres on Jul 8 2018, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 22, 4:01 AM
Unknown Object (File)
Tue, Jul 21, 4:37 AM
Unknown Object (File)
Mon, Jul 20, 2:10 AM
Unknown Object (File)
Sun, Jul 19, 10:36 PM
Unknown Object (File)
Mon, Jul 6, 3:41 AM
Unknown Object (File)
Sat, Jul 4, 8:39 PM
Unknown Object (File)
Sat, Jul 4, 11:03 AM
Unknown Object (File)
Sat, Jul 4, 4:24 AM
Subscribers

Details

Summary

Proposed commit message:

After upgrading to 11.2-RELEASE devel/avarice fails to
compile with:

jtagrw.cc:134:13: error: cannot initialize return object of type 'uchar *' (aka 'unsigned char *') with an rvalue of type 'bool'

            return false;
                   ^~~~~

examination of the code shows another case with a similar
check that returns NULL.

I also filed an upstream bug report:

https://sourceforge.net/p/avarice/bugs/24/

PR: 229376
Reviewed by: ? (mentor)
Approved by: joerg (maintainer), ? (mentor)
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable