Page MenuHomeFreeBSD

graphics/mypaint: force GCC build
ClosedPublic

Authored by jbeich on Jan 23 2015, 1:13 PM.

Details

Reviewers
bapt
flo
Summary

Build using lang/gcc* to avoid runtime issues old -lgcc_s or Clang

Absence of RPATH leads to mypaint loading old libgcc_s.so.1 from base
which later breaks |import numpy| as libgfortran wants newer version.
On 10.0+ the issue is masked by Clang failing instantiate templates.

PR: 188382
PR: 193429
Approved by: bapt (mentor)

Test Plan

poudriere logs are attached to the bugs.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

jbeich retitled this revision from to graphics/mypaint: force GCC build.Jan 23 2015, 1:13 PM
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: flo.
jbeich updated this revision to Diff 3354.
jbeich updated this revision to Diff 3363.Jan 23 2015, 8:44 PM

Also bump PORTREVISION.

jbeich added a reviewer: bapt.Jan 28 2015, 4:32 AM

@flo is taking too long for this trivial change.

bapt edited edge metadata.Jan 28 2015, 8:55 AM
bapt accepted this revision.

Please had a comment about the reason before the uses because on day someone will just go through this port try to build it with clang and remove the uses because it does build properly

This revision is now accepted and ready to land.Jan 28 2015, 8:55 AM
jbeich updated this object.Jan 28 2015, 11:49 AM
jbeich edited edge metadata.
jbeich edited edge metadata.Jan 28 2015, 12:05 PM
jbeich updated this revision to Diff 3489.

Like this? Also see bug 188382 comment 6 and updated commit message.

However, similar issue affecting libstdc++.so is probably more popular/widespread.

This revision now requires review to proceed.Jan 28 2015, 12:05 PM
bapt edited edge metadata.Jan 28 2015, 12:40 PM
bapt accepted this revision.

Yup I also think this is widespreaded but most porters might not be aware of it

This revision is now accepted and ready to land.Jan 28 2015, 12:40 PM
jbeich closed this revision.Jan 28 2015, 1:41 PM

Closed by commit rP378057 (authored by @jbeich).