Extend amount of possible coredumps.
ClosedPublic
Actions

Authored by oshogbo on Jul 3 2018, 10:09 PM.

Details

Reviewers

kib

Commits

Summary

The limitation of number of coredumps is removed.
The amount of digit in the name of corefile is assigned dynamically.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Please regenerate the diff with the context.

sys/kern/kern_sig.c
3217 ↗	(On Diff #44830)	Where this define is used ?
3313 ↗	(On Diff #44830)	Why coding snprintf() by hands ?

Thanks @kib

oshogbo marked 2 inline comments as done.Jul 12 2018, 8:32 AM

sys/kern/kern_sig.c
3331 ↗	(On Diff #45191)	The blank line is not needed.
3444 ↗	(On Diff #45191)	I still do not understand why do you do this manually. How do you try to format the core file name ? printf() family has the format modifiers to align right ('-'), to fill the padding with zeroes ('0') and some other.

oshogbo added inline comments.

sys/kern/kern_sig.c
3331 ↗	(On Diff #45191)	I would prefer to separate those twos.
3444 ↗	(On Diff #45191)	Yeah, but I don't think wee need such sophisticated way. printf with max number should just work fine.