Page MenuHomeFreeBSD

Update the UPDATING file for 'overwrite the oldest coredump'.
ClosedPublic

Authored by oshogbo on Jul 1 2018, 10:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 10:10 AM
Unknown Object (File)
Fri, May 3, 2:08 AM
Unknown Object (File)
Thu, May 2, 9:42 PM
Unknown Object (File)
Jan 12 2024, 10:10 AM
Unknown Object (File)
Dec 20 2023, 12:24 AM
Unknown Object (File)
Nov 14 2023, 7:55 AM
Unknown Object (File)
Nov 12 2023, 6:53 AM
Unknown Object (File)
Nov 11 2023, 10:37 AM
Subscribers
None

Details

Reviewers
bcr
Group Reviewers
manpages
Summary

This review is for UPDATING message for the https://reviews.freebsd.org/D15991 change.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

A few suggestions...

UPDATING
35

The core(5) what? Program, facility, process, functionality? There seems to be something missing here that would clarify what core(5) is.

36

I don't understand this second sentence.
Maybe extend this UPDATING entry a bit to briefly describe the problem (current behaviour: each CPU in the system does a core dump, they are overwriting each other, the last one wins). Then describe the solution or your change: the system will now create a new core dump if there is a free slot or if all slots are taken we will overwrite the oldest one. (from your summary in the other review). Maybe describe what "slot" is in this context. Is it space on the disk, a directory/file, or some kind of entry in a data structure?

@bcr Thanks! You are right. Maybe something like that?

Ah, now even *I* understand it. ;-)
A few fixes to the new text, then it is fine.

UPDATING
6

"a process" or "processes": singular or plural

8

Previously needs to have a comma after it.
s/was/were/
s/kernel/the kernel would/

oshogbo marked an inline comment as done.

@bcr you mean the English speaking peoples? :)
Thanks!

Hehe, yeah. It's good now, ready to commit!

This revision is now accepted and ready to land.Jul 1 2018, 1:43 PM