Page MenuHomeFreeBSD

Support multiple OPAL consoles, and don't crash if uart is not stdout
ClosedPublic

Authored by jhibbits on Jun 29 2018, 7:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 29 2025, 11:17 AM
Unknown Object (File)
Jan 19 2025, 11:49 AM
Unknown Object (File)
Jan 6 2025, 11:39 PM
Unknown Object (File)
Jan 6 2025, 11:02 PM
Unknown Object (File)
Nov 20 2024, 12:57 AM
Unknown Object (File)
Nov 19 2024, 11:53 PM
Unknown Object (File)
Oct 13 2024, 7:57 AM
Unknown Object (File)
Oct 13 2024, 7:57 AM
Subscribers

Details

Summary

If the chosen console is not the OPAL uart, but OPAL uart devices exist, the console device doesn't attach properly, and faults in the interrupt handler, with a NULL pointer dereference. To fix this, and as a byproduct, also support multiple OPAL consoles, refactor to have the console getc callback use the appropriate softc instead of the global console_sc, which may be NULL in the case of a different device being the console.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Assuming you have tested this and it works, looks great.

This revision is now accepted and ready to land.Jun 29 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.