Page MenuHomeFreeBSD

Support multiple OPAL consoles, and don't crash if uart is not stdout
ClosedPublic

Authored by jhibbits on Jun 29 2018, 7:15 PM.

Details

Summary

If the chosen console is not the OPAL uart, but OPAL uart devices exist, the console device doesn't attach properly, and faults in the interrupt handler, with a NULL pointer dereference. To fix this, and as a byproduct, also support multiple OPAL consoles, refactor to have the console getc callback use the appropriate softc instead of the global console_sc, which may be NULL in the case of a different device being the console.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhibbits created this revision.Jun 29 2018, 7:15 PM
nwhitehorn accepted this revision.Jun 29 2018, 7:18 PM

Assuming you have tested this and it works, looks great.

This revision is now accepted and ready to land.Jun 29 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.