Page MenuHomeFreeBSD
Differential D1606

nat/libnatpmp: drop redundant -fPIC from CFLAGS
ClosedPublic
Actions

Authored by jbeich on Jan 23 2015, 2:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 25 2025, 3:10 PM
Unknown Object (File)
Oct 24 2025, 5:13 AM
Unknown Object (File)
Oct 16 2025, 7:02 PM
Unknown Object (File)
Oct 12 2025, 2:25 AM
Unknown Object (File)
Oct 12 2025, 2:25 AM
Unknown Object (File)
Oct 11 2025, 7:57 PM
Unknown Object (File)
Aug 22 2025, 12:16 AM
Unknown Object (File)
Jul 22 2025, 5:08 AM
View All 45 Files
Subscribers
None

Details

Reviewers
crees
bapt
Summary

Drop redundant -fPIC from CFLAGS

PR: 194030 (followup)
Revved by: crees
Approved by: bapt (mentor)

Test Plan

In amd64 logs only -fPIC object files are built, even for static library.

https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147824 (9.3R i386)
http://slexy.org/view/s206TlJWcE (10.0R amd64)
http://slexy.org/view/s21dnWrWxW (8.4R amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jbeich updated this revision to Diff 3337.Jan 23 2015, 2:03 AM
jbeich retitled this revision from to nat/libnatpmp: drop redundant -fPIC from CFLAGS.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: crees, bapt.
bapt accepted this revision.Jan 23 2015, 8:57 AM
bapt edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 8:57 AM
jbeich closed this revision.Feb 1 2015, 4:18 PM

Closed by commit rP378250 (authored by @jbeich).

Revision Contents
Changeset List

PathSize
net/
libnatpmp/
2 lines

Diff 3337

View Options

net/libnatpmp/Makefile

Loading...