Page MenuHomeFreeBSD

Modernize usage of "restrict" keyword in ntp.conf
ClosedPublic

Authored by ian on Jun 23 2018, 2:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 2:17 PM
Unknown Object (File)
Jan 5 2024, 3:26 AM
Unknown Object (File)
Dec 20 2023, 6:23 AM
Unknown Object (File)
Jul 26 2023, 9:54 PM
Unknown Object (File)
Jun 27 2023, 4:06 PM
Unknown Object (File)
Jun 3 2023, 1:50 AM
Unknown Object (File)
May 14 2023, 6:29 AM
Unknown Object (File)
May 5 2023, 8:20 PM
Subscribers

Details

Summary

It is no longer necessary to specify a -4/-6 flag on any ntp.conf keyword. The address type is inferred from the address itself as necessary. "restrict default" statements always apply to both address families regardless of any -4/-6 flag that may be present.

So this change just tidies up our default config by removing the redundant restrict -6 statement and comment, and by removing the -6 flag from the restrict keyword that allows access from localhost.

This change was inspired by the patches provided in PRs 201803 and 210245, and was followed up with some contrib/ntp code inspection to verify that the -4/-6 keywords are basically no-ops in all contexts now.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good.

Thanks for taking care of this.

This revision is now accepted and ready to land.Jun 23 2018, 3:15 AM
This revision was automatically updated to reflect the committed changes.