Page MenuHomeFreeBSD

x11/polybar: Fix build against x11/xcb-proto 1.13.
ClosedPublic

Authored by rigoletto on Jun 22 2018, 1:48 PM.

Details

Summary

PR: 228330

  • bring to ~HEAD
  • add DEBUG OPTION

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rigoletto retitled this revision from x11/polybar: broken. to x11/polybar: Fix build against x11/xcb-proto 1.13..Jun 22 2018, 3:45 PM
rigoletto edited the summary of this revision. (Show Details)

Had to bring localbase:ldflags back, something related with the i3 module needs some patches. I just fail to understand how it was building perfectly fine a few days ago.

x11/polybar/pkg-message
1 ↗(On Diff #44308)

^ I think there is not much gained by this change :D

rigoletto added a subscriber: bapt.

That was my 'set textwidth=80' config in neovim. ^^

Also taking maintainer ship, if @bapt decide to take it later it is fine.

Thanks!

Just bringing to a commit ahead which fix a annoying thing.

Thanks.

Returning to the previous versioning scheme to avoid PORTEPOCH. The next version should not take too long to come out, however the port needs update because it is currently broken.

Thanks!

But now it needs GH_TAGNAME.

x11/polybar/Makefile
4 ↗(On Diff #44353)

^that looks like its going backwards now 23->22

4 ↗(On Diff #44353)

sorry, I was looking at the Diff-between-Diff view -- ignore me :D

The github commit date for new commits are not really helpfull. The fisrt time I looked on there is '8 hours ago' and later '2 days ago'. :-/

rigoletto marked 2 inline comments as done.

Bring back BROKEN_*.

Thanks!

Fix the day of the commit. Thanks! :)

^ don't you need to regenerate the distinfo now?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 26 2018, 7:08 PM
This revision was automatically updated to reflect the committed changes.
head/x11/polybar/Makefile
4

This is wrong.

$ git describe --tags 028b141
3.1.0-161-g028b141

and too late to make this one correctly. Please, read this before inventing another version:

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5