Page MenuHomeFreeBSD

Attach dev.cpu nodes on SMT cores, using only the first found thread
ClosedPublic

Authored by jhibbits on Jun 20 2018, 4:53 AM.

Details

Summary

In order to use cpufreq(4), a dev.cpu attachment must be created. If the IBM property is found denoting SMT, attach only to the first thread setup, so that a cpufreq device can bind.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhibbits created this revision.Jun 20 2018, 4:53 AM
nwhitehorn accepted this revision.Jun 20 2018, 4:59 AM

Approved if you fix the #if 0 bit.

sys/dev/ofw/ofw_cpu.c
199 ↗(On Diff #44127)

Probably this part can just be deleted?

This revision is now accepted and ready to land.Jun 20 2018, 4:59 AM
jhibbits added inline comments.Jun 20 2018, 1:23 PM
sys/dev/ofw/ofw_cpu.c
199 ↗(On Diff #44127)

Yes it can. I had kept it in just for reference, and forgot to delete it.

This revision was automatically updated to reflect the committed changes.