Page MenuHomeFreeBSD
Differential D15921

Attach dev.cpu nodes on SMT cores, using only the first found thread
ClosedPublic
Actions

Authored by jhibbits on Jun 20 2018, 4:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 10:59 PM
Unknown Object (File)
Thu, Jul 2, 2:57 AM
Unknown Object (File)
Wed, Jul 1, 6:52 AM
Unknown Object (File)
Tue, Jun 30, 5:42 PM
Unknown Object (File)
Tue, Jun 30, 11:05 AM
Unknown Object (File)
Thu, Jun 25, 12:47 AM
Unknown Object (File)
Tue, Jun 23, 7:18 PM
Unknown Object (File)
Tue, Jun 23, 5:52 AM
View All Files
Subscribers
imp

Details

Reviewers
nwhitehorn
Commits
rS335442: Attach dev.cpu nodes on powerpc SMT cores, using only the first found thread
Summary

In order to use cpufreq(4), a dev.cpu attachment must be created. If the IBM property is found denoting SMT, attach only to the first thread setup, so that a cpufreq device can bind.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Jun 20 2018, 4:53 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2018, 4:53 AM
Harbormaster completed remote builds in B17473: Diff 44127.Jun 20 2018, 4:53 AM
nwhitehorn accepted this revision.Jun 20 2018, 4:59 AM

Approved if you fix the #if 0 bit.

sys/dev/ofw/ofw_cpu.c
199 ↗(On Diff #44127)

Probably this part can just be deleted?

This revision is now accepted and ready to land.Jun 20 2018, 4:59 AM
jhibbits added inline comments.Jun 20 2018, 1:23 PM
sys/dev/ofw/ofw_cpu.c
199 ↗(On Diff #44127)

Yes it can. I had kept it in just for reference, and forgot to delete it.

Closed by commit rS335442: Attach dev.cpu nodes on powerpc SMT cores, using only the first found thread (authored by jhibbits). · Explain WhyJun 20 2018, 1:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ofw/
41 lines

Diff 44147

View Options

head/sys/dev/ofw/ofw_cpu.c

Loading...