Xen: Added missing check for free callbacks in gnttab_end_foreign_access_references()
ClosedPublic
Actions

Authored by pratyush on Jun 19 2018, 9:11 AM.

Tags

None

Referenced Files

	F132437381: D15899.diff
	Thu, Oct 16, 10:50 PM

	Unknown Object (File)
	Sun, Sep 21, 3:33 AM

	Unknown Object (File)
	Fri, Sep 19, 11:29 PM

	Unknown Object (File)
	Fri, Sep 19, 10:56 PM

	Unknown Object (File)
	Fri, Sep 19, 1:38 PM

	Unknown Object (File)
	Aug 2 2025, 11:16 AM

	Unknown Object (File)
	Jul 25 2025, 11:05 AM

	Unknown Object (File)
	Jul 20 2025, 12:17 AM

View All 77 Files

Subscribers

imp

trasz

Details

Reviewers

royger

Summary

Without a call to check_free_callbacks(), the free callbacks would not be called even when there are sufficient grant references available.

The check was likely left out as a mistake when the function was first added.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

pratyush created this revision.Jun 19 2018, 9:11 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2018, 9:11 AM

LGTM. Will commit it tomorrow unless there are objections.

This revision is now accepted and ready to land.Jun 19 2018, 9:26 AM

trasz added a subscriber: trasz.Jun 19 2018, 3:42 PM

Committed as r335490.

Revision Contents
Changeset List

Path

Size

sys/

dev/

xen/

grant_table/

grant_table.c

1 line

Diff 44063

View Options

sys/dev/xen/grant_table/grant_table.c

Xen: Added missing check for free callbacks in gnttab_end_foreign_access_references()ClosedPublicActions