Xen: Added missing check for free callbacks in gnttab_end_foreign_access_references()
ClosedPublic
Actions

Authored by pratyush on Jun 19 2018, 9:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 26, 12:39 PM

	Unknown Object (File)
	Sat, Sep 26, 1:39 AM

	Unknown Object (File)
	Sun, Sep 20, 10:23 PM

	Unknown Object (File)
	Thu, Sep 17, 9:36 PM

	Unknown Object (File)
	Thu, Sep 17, 7:21 PM

	Unknown Object (File)
	Fri, Sep 11, 7:25 AM

	Unknown Object (File)
	Wed, Sep 9, 11:51 PM

	Unknown Object (File)
	Sep 8 2026, 1:33 PM

View All Files

Subscribers

imp

trasz

Details

Reviewers

royger

Summary

Without a call to check_free_callbacks(), the free callbacks would not be called even when there are sufficient grant references available.

The check was likely left out as a mistake when the function was first added.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

pratyush created this revision.Jun 19 2018, 9:11 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2018, 9:11 AM

LGTM. Will commit it tomorrow unless there are objections.

This revision is now accepted and ready to land.Jun 19 2018, 9:26 AM

trasz added a subscriber: trasz.Jun 19 2018, 3:42 PM

Committed as r335490.

Revision Contents
Changeset List

Path

Size

sys/

dev/

xen/

grant_table/

grant_table.c

1 line

Diff 44063

View Options

sys/dev/xen/grant_table/grant_table.c

Xen: Added missing check for free callbacks in gnttab_end_foreign_access_references()ClosedPublicActions