Page MenuHomeFreeBSD

[New Port] sysutils/ssd_report
ClosedPublic

Authored by dteske on Jun 18 2018, 1:18 AM.

Details

Reviewers
mat
imp
Group Reviewers
portmgr
Commits
rP472896: [New Port] sysutils/ssd_report
Summary

Report SSD health by looking at SMART data.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dteske created this revision.Jun 18 2018, 1:18 AM
dteske updated this revision to Diff 43988.Jun 18 2018, 6:37 AM

Add support for smart utility by Chuck Tuffli

mat added inline comments.Jun 18 2018, 10:49 AM
sysutils/ssd_report/Makefile
16–20 ↗(On Diff #43988)

Use helpers:

smart_RUN_DEPENDS= smart:...
...
32 ↗(On Diff #43988)

Why?

35 ↗(On Diff #43988)

This should not be required.

dteske updated this revision to Diff 44044.Jun 18 2018, 9:34 PM

Address feedback from mat

dteske marked 3 inline comments as done.Jun 18 2018, 9:35 PM
mat accepted this revision.Jun 18 2018, 9:55 PM

The pkg-descr file should be longer too. It should always be at least a couple of lines long.

This revision is now accepted and ready to land.Jun 18 2018, 9:55 PM
dteske updated this revision to Diff 44126.Jun 20 2018, 4:53 AM

Embiggen pkg-descr ^_^

This revision now requires review to proceed.Jun 20 2018, 4:53 AM
mat accepted this revision.Jun 20 2018, 9:04 AM
This revision is now accepted and ready to land.Jun 20 2018, 9:04 AM
dteske updated this revision to Diff 44171.Jun 20 2018, 6:06 PM

Add sysutils/Makefile modification

This revision now requires review to proceed.Jun 20 2018, 6:06 PM
dteske added 1 blocking reviewer(s): portmgr.

Blocked by pre-commit hook:

svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
Do not commit a port with FLAVORS without first
getting approval from portmgr.
mat accepted this revision as: portmgr.Jun 20 2018, 6:29 PM

seriously?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2018, 6:32 PM
This revision was automatically updated to reflect the committed changes.