Merge header updates from the English version
ClosedPublic
Actions

Authored by ygy on Jun 15 2018, 11:22 PM.

Details

Reviewers

loader
delphij

Commits

rD51843: Merge header updates from the English version.

Summary

Merge header updates from the English version.

MFen: r49777 -> r51827
Reviewed_by: loader (mentor), delphij (mentor)
Approved_by: loader (mentor), delphij (mentor)
Differential_Revision: https://reviews.freebsd.org/D1XXXX

Test Plan

Build: OK
http://ci.charlieyang.me:8180/jenkins/job/freebsd-doc-web-only/56/

Deploy: OK
https://charlieyang.me/freebsd-doc-web-deploy/zh_CN/

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ygy created this revision.Jun 15 2018, 11:22 PM

ygy updated this revision to Diff 43858.Jun 15 2018, 11:28 PM

ygy edited the summary of this revision. (Show Details)

ygy edited the test plan for this revision. (Show Details)

ygy added reviewers: loader, delphij.

ygy set the repository for this revision to rD FreeBSD doc repository - subversion.

LGTM in principal.

Should we translate terms like "Repository", etc.? It might be confusing for a newcomer what is "Phabricator" by the way, but it might need to be addressed in the English version as well.

This revision is now accepted and ready to land.Jun 15 2018, 11:38 PM

In D15838#334908, @delphij wrote:

LGTM in principal.

Should we translate terms like "Repository", etc.? It might be confusing for a newcomer what is "Phabricator" by the way, but it might need to be addressed in the English version as well.

Filed a PR at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229056 for "Phabricator".

Will add translation to more terms in a separate review.

loader accepted this revision.Jun 16 2018, 3:49 AM

Closed by commit rD51843: Merge header updates from the English version. (authored by ygy). · Explain WhyJun 16 2018, 6:03 AM

This revision was automatically updated to reflect the committed changes.