Page MenuHomeFreeBSD
Differential D1578

Unbreak openoffice-devel fetch
ClosedPublic
Actions

Authored by truckman on Jan 21 2015, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 4:28 AM
Unknown Object (File)
Feb 1 2024, 8:38 AM
Unknown Object (File)
Jan 20 2024, 5:44 AM
Unknown Object (File)
Jan 12 2024, 1:19 AM
Unknown Object (File)
Dec 20 2023, 5:40 AM
Unknown Object (File)
Dec 12 2023, 8:11 AM
Unknown Object (File)
Nov 21 2023, 12:06 PM
Unknown Object (File)
Aug 28 2023, 10:03 AM
View All 39 Files
Subscribers
None

Details

Reviewers
pfg
mat
Commits
rP377630: Unbreak fetch.
Summary

Fix a DISTFILE tag typo that broke fetch

Test Plan

make fetch

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

truckman updated this revision to Diff 3297.Jan 21 2015, 7:25 PM
truckman retitled this revision from to Unbreak openoffice-devel fetch.
truckman updated this object.
truckman edited the test plan for this revision. (Show Details)
truckman added reviewers: mat, pfg.
mat accepted this revision.Jan 21 2015, 9:43 PM
mat edited edge metadata.

Now, you made me look bad by approving a broken thing in the first place :-p

This revision is now accepted and ready to land.Jan 21 2015, 9:43 PM
mat requested changes to this revision.Jan 21 2015, 9:45 PM
mat edited edge metadata.

You need to add a PKGNAMESUFFIX=-devel

Both openoffice-4 and -devel have the same pkgname, it is bad.

This revision now requires changes to proceed.Jan 21 2015, 9:45 PM
pfg accepted this revision.Jan 21 2015, 10:45 PM
pfg edited edge metadata.

With this change it is downloading now.
FWIW, I see
PKGNAMESUFFIX= -devel
on line 17 (but I just updated my ports tree)

truckman updated this revision to Diff 3300.Jan 21 2015, 10:51 PM
truckman edited edge metadata.
truckman updated this object.
truckman edited the test plan for this revision. (Show Details)

Merge r377624: Fix duplicate pkgnames

truckman added a comment.Jan 21 2015, 10:55 PM
In D1578#6, @mat wrote:

You need to add a PKGNAMESUFFIX=-devel

Both openoffice-4 and -devel have the same pkgname, it is bad.

antoine caught that right away and fixed that in r377624

truckman added a comment.Jan 21 2015, 10:56 PM
In D1578#3, @mat wrote:

Now, you made me look bad by approving a broken thing in the first place :-p

Yeah I broke both fetch and index.

truckman closed this revision.Jan 21 2015, 10:57 PM
truckman updated this revision to Diff 3301.

Closed by commit rP377630 (authored by @truckman).

mat added inline comments.Jan 21 2015, 11:35 PM
head/editors/openoffice-devel/Makefile
14–17

Well, now, I don't know if LANG_SUFFIX is ever used, but it will never do anything, as PKGNAMESUFFIX is overwritten just after :-)

truckman added inline comments.Jan 21 2015, 11:44 PM
truckman added inline comments.Jan 21 2015, 11:47 PM
head/editors/openoffice-devel/Makefile
14–17

Looks like I have to leave fixing LANG_SUFFIX to another day.

pfg added a comment.Jan 22 2015, 12:49 AM

FWIW, naming issues should probably be reviewed by Maho-san, he's the local expert.

truckman added a comment.Jan 22 2015, 12:53 AM

Last time I pinged him, he wasn't even in a position to do a build test.

pfg added a comment.Jan 22 2015, 1:20 AM

Yes, he is a busy guy but if you have doubts about the naming ask him ... he has much more experience from the pre-apache days.

Revision Contents
Changeset List

PathSize
head/
editors/
openoffice-devel/
2 lines

Diff 3301

View Options

head/editors/openoffice-devel/Makefile

Loading...