Page MenuHomeFreeBSD
Differential D15736

Implement fast path for malloc and free
AbandonedPublic
Actions

Authored by mjg on Jun 10 2018, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 12:20 PM
Unknown Object (File)
Thu, Jan 30, 6:56 AM
Unknown Object (File)
Wed, Jan 29, 2:13 PM
Unknown Object (File)
Wed, Jan 29, 1:00 PM
Unknown Object (File)
Thu, Jan 23, 7:37 PM
Unknown Object (File)
Tue, Jan 21, 1:03 AM
Unknown Object (File)
Mon, Jan 20, 9:23 PM
Unknown Object (File)
Sun, Jan 19, 2:16 PM
View All 34 Files
Subscribers
imp

Details

Reviewers
jeff
markj
Summary

Avoids func calls and branches in the common case.

malloc+free throughput per second: ~19323918 to ~27418181.

lock1 from will-it-scale (single-threaded): 2196902 -> 2345506

Test Plan

make universe. running with DEBUG_REDZONE and DEBUG_MEMGUARD

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg created this revision.Jun 10 2018, 1:36 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 10 2018, 1:36 PM
Harbormaster completed remote builds in B17135: Diff 43543.Jun 10 2018, 1:36 PM
jeff added a comment.Jun 11 2018, 1:30 AM

Does this not include the malloc.h changes for M_ZERO?

Can we do constant size at the same time?

sys/kern/kern_malloc.c
656–662

This should be a uma_int.h inline.

867–871

Should also be an inline. Possibly with some of the code above.

markj added a reviewer: markj.Sep 6 2018, 3:18 PM
mjg updated this revision to Diff 48391.Sep 24 2018, 12:22 PM
  • rebased
mjg added a comment.Sep 25 2018, 10:40 AM

The M_ZERO stuff went in quite some time ago.

I plan to deal with static one lookup later.

I don't think the inlined cache bump matters. But if you insist i can move it to a dedicated routine.

mjg planned changes to this revision.Aug 31 2019, 9:50 AM

Apart from addressing this review request this needs some reworking due to other changes in uma.

mjg abandoned this revision.Mar 12 2024, 10:30 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
208 lines
vm/
9 lines
8 lines

Diff 48391

View Options

sys/kern/kern_malloc.c

Loading...
View Options

sys/vm/uma_core.c

Loading...
View Options

sys/vm/uma_dbg.h

Loading...