readelf: Add missing R_X86_64_ relocation types
ClosedPublic
Actions

Authored by emaste on Jan 20 2015, 10:27 PM.

Tags

None

Referenced Files

	F94599892: D1570.diff
	Tue, Sep 17, 8:02 PM

	Unknown Object (File)
	Fri, Sep 13, 5:05 AM

	Unknown Object (File)
	Tue, Sep 10, 4:00 PM

	Unknown Object (File)
	Sun, Sep 8, 8:44 PM

	Unknown Object (File)
	Sun, Sep 8, 11:39 AM

	Unknown Object (File)
	Sun, Sep 8, 4:24 AM

	Unknown Object (File)
	Sun, Sep 8, 12:31 AM

	Unknown Object (File)
	Sun, Sep 1, 10:11 PM

Subscribers

None

Details

Reviewers

dim

Commits

rS277462: redelf: Add missing R_X86_64_ relocation types

Summary

Add relocation types from LLVM's Support/ELFRelocs/x86_64.def.

These will be committed to my ELF Tool Chain fork and then brought into contrib/elftoolchain, along with a corresponding sys/elf_common.h change.

Lint

Lint Skipped

Unit

Tests Skipped

emaste retitled this revision from to readelf: Add missing R_X86_64_ relocation types.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: dim.

LGTM.

readelf/readelf.c
1482	Maybe in a later revision, change all the hardcoded numbers in this switch to the ones defined above in elfdefinitions.h? Having the same magic numbers twice is very error prone, and llvm already replaced this with a table-generated approach. :-)

This revision is now accepted and ready to land.Jan 20 2015, 10:48 PM