sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1)
ClosedPublic
Actions

Authored by dteske on May 30 2018, 6:39 PM.

Details

Reviewers

mat
imp

Commits

rP471295: sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1)

Summary

sysutils/dwatch-{gource,pwsnoop} require dwatch(1) in FreeBSD base.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dteske created this revision.May 30 2018, 6:39 PM

Harbormaster completed remote builds in B16919: Diff 43158.May 30 2018, 6:39 PM

mat added inline comments.May 31 2018, 10:30 AM

sysutils/dwatch-gource/Makefile
24–34 ↗	(On Diff #43158)	I wonder, could you please write this using only three lines and not 11 ?

Refactor IGNORE

Harbormaster completed remote builds in B16949: Diff 43211.May 31 2018, 5:46 PM

Also note: I removed check of OPSYS because it looks like it can be "DragonFly" which in my mind would have an OSVERSION that tracks with FreeBSD's. Willing to put back OPSYS check, thoughts?

thanks, looks good now.

mat accepted this revision.Jun 1 2018, 10:10 AM

This revision is now accepted and ready to land.Jun 1 2018, 10:10 AM

Closed by commit rP471295: sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1) (authored by dteske). · Explain WhyJun 1 2018, 9:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sysutils/

dwatch-gource/

Makefile

6 lines

dwatch-pwsnoop/

Makefile

6 lines

Diff 43256

View Options

head/sysutils/dwatch-gource/Makefile