Page MenuHomeFreeBSD

Cover using symbolic names for interfaces in VLAN article of handbook.
ClosedPublic

Authored by sevan on May 26 2018, 6:49 PM.

Details

Summary

Bug 228231
Brian Haug haug.bsd6114 AT yahoo

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sevan created this revision.May 26 2018, 6:49 PM
bcr added a comment.Jun 10 2018, 3:48 PM

A few corrections and sentence rephrasing.

en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
5274 ↗(On Diff #43043)

This line needs to be connected to the sentence above (after the sentence stop) and reflowed properly.

5276 ↗(On Diff #43043)

Same here.

5281 ↗(On Diff #43043)

Don't use "I" in the handbook. Make it third-person, like this:

For example, interfaces for video and audio can be named to associate ...

5292 ↗(On Diff #43043)

This needs to be wrapped in <replaceable>s as the address is not static.

5298 ↗(On Diff #43043)

s/interfaces/interface/

This sentence could be a bit shorter to simply say: For an interface named <literal>video</literal> use the following:

5303 ↗(On Diff #43043)

s/confguration/configuration/

I'd write the sentence as follows: To apply the changes at boot time, add ...

sevan updated this revision to Diff 43551.Jun 10 2018, 5:34 PM

Address the points.

sevan marked 5 inline comments as done.Jun 10 2018, 5:36 PM
sevan updated this revision to Diff 43555.Jun 10 2018, 6:13 PM

another run.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2018, 6:31 PM
This revision was automatically updated to reflect the committed changes.