Exit with an error if a linker hints file can't be found.
ClosedPublic
Actions

Authored by jhb on May 25 2018, 9:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 10, 6:19 PM

	Unknown Object (File)
	Thu, Apr 9, 5:50 AM

	Unknown Object (File)
	Mon, Apr 6, 12:58 PM

	Unknown Object (File)
	Mon, Apr 6, 5:57 AM

	Unknown Object (File)
	Sat, Mar 28, 6:03 AM

	Unknown Object (File)
	Fri, Mar 27, 10:03 PM

	Unknown Object (File)
	Sun, Mar 22, 4:29 PM

	Unknown Object (File)
	Mar 8 2026, 7:38 PM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rS335181: Exit with an error if a linker hints file can't be found.

Summary

Continuing with a NULL hints variable just triggers a segfault later on.
The other error cases in this function all exit for an error rather than
warning.

Test Plan

boot a mips image under qemu. devmatch core dumped previously, not it just exits after the error message

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 25 2018, 9:53 PM

Harbormaster completed remote builds in B16852: Diff 43020.May 25 2018, 9:53 PM

Ping

imp accepted this revision.Jun 13 2018, 7:09 PM

This revision is now accepted and ready to land.Jun 13 2018, 7:09 PM

Closed by commit rS335181: Exit with an error if a linker hints file can't be found. (authored by jhb). · Explain WhyJun 14 2018, 10:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

devmatch/

devmatch.c

8 lines

Diff 43789

View Options

head/sbin/devmatch/devmatch.c

Exit with an error if a linker hints file can't be found.ClosedPublicActions