Page MenuHomeFreeBSD

Fix an uninitialized variable as well as an stdarg cleanup. (CID: 1194318 and 1194332)
AbandonedPublic

Authored by araujo on May 24 2018, 4:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 4 2024, 11:29 AM
Unknown Object (File)
Dec 31 2023, 6:00 AM
Unknown Object (File)
Dec 20 2023, 7:32 AM
Unknown Object (File)
Jul 25 2023, 10:42 AM
Unknown Object (File)
Jun 3 2023, 1:48 AM
Unknown Object (File)
May 14 2023, 6:26 AM
Unknown Object (File)
Dec 28 2022, 12:57 AM
Subscribers

Details

Reviewers
rgrimes
Summary

CID 1194318: We call the macro EFPRINTF without initialize the variable err.
CID 1194332: stdarg(3) says that each invocation of va_start() must be paired with a corresponding invocation of va_end() in the same function. In this case if an error occur with vfprintf() we forget to call va_end(ap).

Test Plan

Tested with FreeeBSD HEAD as a vm guest.
Tested with Fedora as a vm guest.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16801
Build 16686: arc lint + arc unit

Event Timeline

araujo edited the summary of this revision. (Show Details)

oooops, I opened a revision with the wrong file 🗡