Page MenuHomeFreeBSD
Differential D1551

MFV r266993: 4469 DTrace helper tracing should be dynamic
ClosedPublic
Actions

Authored by pfg on Jan 17 2015, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 30, 11:41 PM
Unknown Object (File)
Tue, Sep 29, 9:17 AM
Unknown Object (File)
Tue, Sep 29, 8:41 AM
Unknown Object (File)
Tue, Sep 29, 1:34 AM
Unknown Object (File)
Sat, Sep 26, 10:37 PM
Unknown Object (File)
Fri, Sep 18, 7:55 AM
Unknown Object (File)
Sep 11 2026, 4:45 AM
Unknown Object (File)
Sep 10 2026, 11:42 PM
View All Files
Subscribers
None

Details

Reviewers
markj
Summary

Obtained from illumos
illumos/illumos-gate@902686d13f8a39cfdc57f5605470369eafa51e1f

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

pfg updated this revision to Diff 3228.Jan 17 2015, 7:54 PM
pfg retitled this revision from to MFV r266993: 4469 DTrace helper tracing should be dynamic.
pfg updated this object.
pfg edited the test plan for this revision. (Show Details)
pfg added a reviewer: markj.
pfg added a comment.Jan 17 2015, 8:00 PM

Please note that the files in sys/cddl/dev/dtrace don't seem to exist in illumos.

markj added inline comments.Jan 23 2015, 11:01 PM
sys/cddl/dev/dtrace/dtrace_load.c
139–140

This block was moved upstream. You added it to dtrace_open() but also left it here - why?

pfg updated this revision to Diff 3598.Feb 2 2015, 11:20 PM

Drop the allocation and freeing blocks from dtrace_load() and
dtrace_unload(). Untested.

Thanks to Mark for noticing!

markj added inline comments.Feb 3 2015, 4:07 AM
sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c
16900

This call is not a part of this change, it should be removed. Then I think you're good to go.

pfg updated this revision to Diff 3616.Feb 3 2015, 6:49 PM

Update wrt head r278137.

Updating D1551: MFV r266993:

4469 DTrace helper tracing should be dynamic

markj accepted this revision.Feb 3 2015, 7:03 PM
markj edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 7:03 PM
pfg closed this revision.Feb 6 2015, 2:28 PM

Committed as r278166.
Thanks!

sys/cddl/dev/dtrace/dtrace_load.c
139–140

Have you seen which commit moved this? I just couldn't find it because dtrace_load.c doesn't exist anymore upstream.

I only noticed this occurrence of dtrace_help_enabled because it broke the build.

pfg mentioned this in rS284136: MFC r278166, MFV r266993:.Jun 7 2015, 8:45 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
dtrace/
87 lines
dev/
dtrace/
11 lines
5 lines

Diff 3616

View Options

sys/cddl/contrib/opensolaris/

Loading...
View Options

sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c

Loading...
View Options

sys/cddl/dev/dtrace/dtrace_load.c

Loading...
View Options

sys/cddl/dev/dtrace/dtrace_unload.c

Loading...