Page MenuHomeFreeBSD

emulators/wine: patch wine.desktop
ClosedPublic

Authored by tcberner on May 19 2018, 5:23 PM.

Details

Summary

The installed wine.desktop points to wine instead of wine64 on amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Thanks for reporting this and submitting a patch.

I will admit I started at the diff for the change related to wineapploader.in for a bit (looking at the patch in the e-mail first) unitl I realized you just added a trailing space. Please don't do that (and review the final patch before submitting it).

Can you please break the sentence in the comment, something like "Also fix the desktop file." and format not to exceed 78 columns (which predates your patch, but since we are touching that line anyway)?

The change as such looks fine to me with the two caveates above, but let's give David (Naylor) a chance to chime in. If you don't hear from him within a couple of days, it's okay to proceed.

Looks good to me. Please revert the white-space change then commit.

This revision is now accepted and ready to land.Jun 3 2018, 2:35 PM
This revision was automatically updated to reflect the committed changes.

By the way: Should the same patch be applied to the wine-devel port as well?

If so, please go ahead (it's pre-approved). Thanks!