Differential D15476

Quiesce build errors with cast to u_int8_t
ClosedPublic
Actions

Authored by sbruno on May 18 2018, 1:55 PM.

Tags

None

Referenced Files

	F170862538: D15476.diff
	Mon, Sep 7, 2:54 AM

	Unknown Object (File)
	Fri, Sep 4, 7:28 PM

	Unknown Object (File)
	Fri, Sep 4, 4:31 PM

	Unknown Object (File)
	Thu, Sep 3, 9:18 PM

	Unknown Object (File)
	Thu, Sep 3, 4:47 PM

	Unknown Object (File)
	Thu, Sep 3, 11:27 AM

	Unknown Object (File)
	Thu, Sep 3, 8:20 AM

	Unknown Object (File)
	Thu, Sep 3, 6:11 AM

Subscribers

Details

Reviewers

adrian
imp

Commits

rS333801: Quiesce a couple pages of clang warnings with a cast. Duplicates

Summary

Linux has been casting this macro for a while now. Do the same thing to quiesce a bazillon build warnings.

Ref:

https://github.com/torvalds/linux/commit/627871b71c89a6ec12fbed75063f238e0c7127b2#diff-8c6ddb4c3ad69a6fb9f289475821db56

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sbruno created this revision.May 18 2018, 1:55 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 18 2018, 1:55 PM

Harbormaster completed remote builds in B16665: Diff 42695.May 18 2018, 1:55 PM

sbruno edited the summary of this revision. (Show Details)May 18 2018, 1:58 PM

imp added inline comments.May 18 2018, 5:05 PM

sys/contrib/dev/ath/ath_hal/ar9300/ar9300eep.h
142 ↗	(On Diff #42695)	uint8_t please

sbruno added inline comments.May 18 2018, 5:13 PM

sys/contrib/dev/ath/ath_hal/ar9300/ar9300eep.h
142 ↗	(On Diff #42695)	I used the "style" of the file that this is declared in. I don't have an opinion here, but I wanted to keep the file consistent.

imp accepted this revision.May 18 2018, 5:15 PM

imp added inline comments.

sys/contrib/dev/ath/ath_hal/ar9300/ar9300eep.h
142 ↗	(On Diff #42695)	Fair enough. It's a bit of a reflex these days :(

This revision is now accepted and ready to land.May 18 2018, 5:15 PM

Closed by commit rS333801: Quiesce a couple pages of clang warnings with a cast. Duplicates (authored by sbruno). · Explain WhyMay 18 2018, 5:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

contrib/

dev/

ath/

ath_hal/

ar9300/

2 lines

Diff 42704

head/sys/contrib/dev/ath/ath_hal/ar9300/ar9300eep.h

Loading...