Details
Details
- Reviewers
andrew
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Some of the files in what is now sys/boot/efi/loader are amd64 specific. It may make more seance to pull out anything common with arm64 into sys/boot/efi/libefi. I know we share at least a few commands, but would need to look through the two sets of files to know how similar they are.
sys/boot/efi/boot1/Makefile | ||
---|---|---|
16 | While here can you put start.S first? It will need to be first on arm64. | |
33 | -Wl,-znocombreloc stops boot1.efi from working on arm64, it would be nice if it was on a separate line, e.g. LDFLAGS+= -Wl,-znocombreloc. This would simplify when we pull this change across. |
Comment Actions
Perhaps boot/efi/loader/${ARCH} (or boot/efi/${ARCH}, depending on what we could share between boot1 and loader).
sys/boot/efi/boot1/Makefile | ||
---|---|---|
33 | OK |