I've attempted to add the server component such that the
game can be installed with/without the server and that the server
can be installed with/without the required mysql server backend.
Details
- Reviewers
- None
- Commits
- rP470321: games/cockatrice
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 16638 Build 16543: arc lint + arc unit
Event Timeline
games/cockatrice/Makefile | ||
---|---|---|
11 | too long | |
20–21 | USES should happen earlier. See Order of Variables in Port Makefiles. | |
29 | Use OPTIONS_SUB instead. | |
30–32 | Use options helpers. |
Switch top options helper and OPTIONS_SUB where possible. I still
am not clear on how to make USE_QT5 do the right thing in this
framework.
I can't seem to get USE_QT5 to do anything with the OPTIONS_SUB framework. Does it work?
games/cockatrice/Makefile | ||
---|---|---|
27 | SERVATRICE_USE= qt5+="sql sql-mysql websockets" |
games/cockatrice/Makefile | ||
---|---|---|
27 | Hrm. I don't think I have the right syntax. I keep getting QT5 failures: https://people.freebsd.org/~sbruno/Makefile.txt https://people.freebsd.org/~sbruno/Cockatrice-2.5.1.g2018.04.16_1.log |
games/cockatrice/Makefile | ||
---|---|---|
27 | It doesn't look like OPTIONS_SUB support "qt5+=" |
Use the proper syntax for USE_QT5= for the global QT5 requires.
Use the proper syntax for OPTIONS_USE= qt5="" so that different
options pull in their required deps. (thanks mat).