I've attempted to add the server component such that the
game can be installed with/without the server and that the server
can be installed with/without the required mysql server backend.
Details
Details
- Reviewers
- None
- Commits
- rP470321: games/cockatrice
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| games/cockatrice/Makefile | ||
|---|---|---|
| 11 ↗ | (On Diff #42485) | too long |
| 31 ↗ | (On Diff #42485) | USES should happen earlier. See Order of Variables in Port Makefiles. |
| 41 ↗ | (On Diff #42485) | Use OPTIONS_SUB instead. |
| 42–44 ↗ | (On Diff #42485) | Use options helpers. |
Comment Actions
Switch top options helper and OPTIONS_SUB where possible. I still
am not clear on how to make USE_QT5 do the right thing in this
framework.
Comment Actions
I can't seem to get USE_QT5 to do anything with the OPTIONS_SUB framework. Does it work?
| games/cockatrice/Makefile | ||
|---|---|---|
| 44 ↗ | (On Diff #42600) | SERVATRICE_USE= qt5+="sql sql-mysql websockets" |
| games/cockatrice/Makefile | ||
|---|---|---|
| 44 ↗ | (On Diff #42600) | Hrm. I don't think I have the right syntax. I keep getting QT5 failures: https://people.freebsd.org/~sbruno/Makefile.txt https://people.freebsd.org/~sbruno/Cockatrice-2.5.1.g2018.04.16_1.log |
| games/cockatrice/Makefile | ||
|---|---|---|
| 44 ↗ | (On Diff #42600) | It doesn't look like OPTIONS_SUB support "qt5+=" |
Comment Actions
Use the proper syntax for USE_QT5= for the global QT5 requires.
Use the proper syntax for OPTIONS_USE= qt5="" so that different
options pull in their required deps. (thanks mat).