Page MenuHomeFreeBSD
Differential D15396

Fix directory blocks checksumming.
ClosedPublic
Actions

Authored by fsu on May 11 2018, 6:54 PM.
Tags
None
Referenced Files
F110279321: D15396.diff
Sun, Feb 16, 3:58 AM
Unknown Object (File)
Mon, Feb 3, 2:24 PM
Unknown Object (File)
Fri, Jan 24, 11:41 AM
Unknown Object (File)
Sat, Jan 18, 10:13 PM
Unknown Object (File)
Sat, Jan 18, 9:58 PM
Unknown Object (File)
Jan 15 2025, 7:12 AM
Unknown Object (File)
Nov 21 2024, 10:33 PM
Unknown Object (File)
Nov 19 2024, 11:52 PM
View All 33 Files
Subscribers
imp

Details

Reviewers
kevlo
pfg
Commits
rS333586: Fix directory blocks checksumming.
Summary

Add additional metadata_csum feature functionality for htree and directory blocks.

Test Plan

Tested using typical fsx/fstorture scenarios on ext4 drive with metadata_csum feature turned on.
Testing scripts could be provided by request.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fsu created this revision.May 11 2018, 6:54 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 11 2018, 6:54 PM
pfg accepted this revision.May 12 2018, 3:01 AM
pfg added inline comments.
fs/ext2fs/ext2_csum.c
557 ↗(On Diff #42418)

Minor knit, can you move the gen assignment (line 554) right here before its first use?

Not really necessary, just me being icky ;).

This revision is now accepted and ready to land.May 12 2018, 3:01 AM
fsu added inline comments.May 13 2018, 8:04 AM
fs/ext2fs/ext2_csum.c
557 ↗(On Diff #42418)

Yep, it will be more correct. Will be fixed before commit.

Closed by commit rS333586: Fix directory blocks checksumming. (authored by fsu). · Explain WhyMay 13 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
ext2fs/
88 lines
11 lines
68 lines
3 lines
8 lines
15 lines

Diff 42498

View Options

head/sys/fs/ext2fs/ext2_csum.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_extern.h

Loading...
View Options

head/sys/fs/ext2fs/ext2_htree.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_inode_cnv.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_lookup.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_vnops.c

Loading...