Fix on-disk inode checksum calculation logic.
ClosedPublic
Actions

Authored by fsu on May 11 2018, 6:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 8:29 PM

	Unknown Object (File)
	Mon, May 18, 8:29 PM

	Unknown Object (File)
	Mon, May 18, 8:29 PM

	Unknown Object (File)
	Mon, May 18, 8:24 PM

	Unknown Object (File)
	Sun, Apr 26, 11:23 AM

	Unknown Object (File)
	Apr 22 2026, 12:20 AM

	Unknown Object (File)
	Apr 22 2026, 12:11 AM

	Unknown Object (File)
	Apr 21 2026, 4:32 PM

View All 95 Files

Subscribers

imp

Details

Reviewers

kevlo
pfg

Commits

rS333585: Fix on-disk inode checksum calculation logic.

Summary

The next items were fixed:

Remove double on-disk inode check for zeros. Now it will be done only if the checksum check was failed.
Fix on-disk inode checksum calculation function to do not modify on-disk inode checksum field.

Test Plan

Just create some new files on ext4 volume with metadata_csum feature should be enough.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fsu created this revision.May 11 2018, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 11 2018, 6:54 PM

Looks good to me

fs/ext2fs/ext2_csum.c
602 ↗	(On Diff #42416)	Remove excessive commas: * it is expected that it will be zeroed

This revision is now accepted and ready to land.May 12 2018, 2:54 AM

fsu added inline comments.May 13 2018, 8:02 AM

fs/ext2fs/ext2_csum.c
602 ↗	(On Diff #42416)	Yep, too many commas), will be fixed in the committed version.

Closed by commit rS333585: Fix on-disk inode checksum calculation logic. (authored by fsu). · Explain WhyMay 13 2018, 7:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

ext2fs/

ext2_csum.c

60 lines

ext2_inode_cnv.c

9 lines

Diff 42494

View Options

head/sys/fs/ext2fs/ext2_csum.c