Page MenuHomeFreeBSD

Fix on-disk inode checksum calculation logic.
ClosedPublic

Authored by fsu on May 11 2018, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 2 2024, 6:58 AM
Unknown Object (File)
Sep 23 2024, 10:32 PM
Unknown Object (File)
Sep 23 2024, 7:56 PM
Unknown Object (File)
Sep 16 2024, 10:55 AM
Unknown Object (File)
Sep 8 2024, 7:53 AM
Unknown Object (File)
Aug 29 2024, 4:21 AM
Unknown Object (File)
Aug 19 2024, 2:20 AM
Unknown Object (File)
Jul 12 2024, 1:47 PM
Subscribers

Details

Summary

The next items were fixed:

  • Remove double on-disk inode check for zeros. Now it will be done only if the checksum check was failed.
  • Fix on-disk inode checksum calculation function to do not modify on-disk inode checksum field.
Test Plan

Just create some new files on ext4 volume with metadata_csum feature should be enough.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me

fs/ext2fs/ext2_csum.c
602 ↗(On Diff #42416)

Remove excessive commas:

* it is expected that it will be zeroed
This revision is now accepted and ready to land.May 12 2018, 2:54 AM
fs/ext2fs/ext2_csum.c
602 ↗(On Diff #42416)

Yep, too many commas), will be fixed in the committed version.

This revision was automatically updated to reflect the committed changes.