Differential D15394

Fix EXT2FS_DEBUG definition usage.
ClosedPublic
Actions

Authored by fsu on May 11 2018, 6:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 18, 1:34 PM

	Unknown Object (File)
	Sat, Jul 18, 9:27 AM

	Unknown Object (File)
	Thu, Jul 9, 3:11 AM

	Unknown Object (File)
	Wed, Jul 8, 7:27 AM

	Unknown Object (File)
	Fri, Jul 3, 4:56 PM

	Unknown Object (File)
	Fri, Jul 3, 6:53 AM

	Unknown Object (File)
	Thu, Jul 2, 8:25 PM

	Unknown Object (File)
	Jun 8 2026, 6:56 AM

Subscribers

Details

Reviewers

kevlo
pfg

Commits

rS333584: Fix EXT2FS_DEBUG definition usage.

Summary

It had to be done a long time ago. The debug configuration was broken, and now it is fixed for both i386 and x86_64.
To turn on the additional log capabilities it is needed to just un-comment #define EXT2FS_DEBUG in the ./ext2fs/fs.h header.
Also, the debug logs formatting was checked and fixed too.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fsu created this revision.May 11 2018, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 11 2018, 6:54 PM

pfg accepted this revision.May 12 2018, 2:50 AM

pfg added inline comments.

fs/ext2fs/fs.h
165 ↗	(On Diff #42415)	Remove "it" : * Use if additional debug logging is desired. Also avoid mixing /* / with //, use the regular C comment / */ for the # define.

This revision is now accepted and ready to land.May 12 2018, 2:50 AM

fsu added inline comments.May 13 2018, 8:00 AM

fs/ext2fs/fs.h
165 ↗	(On Diff #42415)	Ok, the updated version will be committed.

Closed by commit rS333584: Fix EXT2FS_DEBUG definition usage. (authored by fsu). · Explain WhyMay 13 2018, 7:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

ext2fs/

4 lines

2 lines

2 lines

12 lines

1 line

1 line

1 line

ext2_inode_cnv.c

12 lines

1 line

1 line

4 lines

1 line

5 lines

Diff 42493

head/sys/fs/ext2fs/ext2_alloc.c

Loading...

head/sys/fs/ext2fs/ext2_bmap.c

Loading...

head/sys/fs/ext2fs/ext2_extents.h

Loading...

head/sys/fs/ext2fs/ext2_extents.c

Loading...

head/sys/fs/ext2fs/ext2_hash.c

Loading...

head/sys/fs/ext2fs/ext2_htree.c

Loading...

head/sys/fs/ext2fs/ext2_inode.c

Loading...

head/sys/fs/ext2fs/ext2_inode_cnv.c

Loading...

head/sys/fs/ext2fs/ext2_lookup.c

Loading...

head/sys/fs/ext2fs/ext2_subr.c

Loading...

head/sys/fs/ext2fs/ext2_vfsops.c

Loading...

head/sys/fs/ext2fs/ext2_vnops.c

Loading...

head/sys/fs/ext2fs/fs.h

Loading...