Page MenuHomeFreeBSD

Make kernel config options available to module load, and use them to solve some problems.
ClosedPublic

Authored by imp on Jan 15 2015, 1:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 4:10 AM
Unknown Object (File)
Wed, Dec 18, 3:22 AM
Unknown Object (File)
Thu, Dec 5, 6:26 PM
Unknown Object (File)
Nov 3 2024, 4:37 PM
Unknown Object (File)
Oct 21 2024, 11:54 PM
Unknown Object (File)
Oct 7 2024, 6:33 PM
Unknown Object (File)
Oct 7 2024, 9:23 AM
Unknown Object (File)
Oct 6 2024, 3:45 PM
Subscribers

Details

Summary

Populate new KERN_OPTS from all the opt_*.h files in
KERNBUILDDIR. Come up with some sensible defaults (though listing them
in kmod.mk may be unwise -- we have no easy way to know what are the
best sensible defaults for everything so we just catch.the big stuff).
Append SRCS.${opt} for each option in KERN_OPTS to SRCS to allow easy
conditional compilation. Append any notion of KERN_OPTS_EXTRA to the
list of kernel opts.

Use this feature to clean up INET, INTE6, EISA stuff in the tree, as
well as enhance the ed module to be more flexible as an example.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

imp retitled this revision from to New KERN_OPTS stuff.
imp updated this object.
imp edited the test plan for this revision. (Show Details)

Hm, gotta be careful with IEEE80211_DEBUG - it changes the API and modules don't load. :(

I just listed the ones already in kmod.mk

imp retitled this revision from New KERN_OPTS stuff to Make kernel config options available to module load, and use them to solve some problems..Jan 15 2015, 4:07 PM
imp added a reviewer: jhb.

I like the concept certainly. I would probably vote for committing the infrastructure as one change and then using followups for cleanups and adding more uses of SRCS.<foo>

sys/conf/options
400 ↗(On Diff #3187)

Might as well put this in opt_pci.h instead of opt_global.h? (I.e. I would err on not putting things in opt_global.h if possible)

sys/modules/ep/Makefile
15 ↗(On Diff #3187)

Perhaps leave the commented out mca line for now. Removing that probably warrants being done in a separate commit?

sys/modules/if_gif/Makefile
14 ↗(On Diff #3187)

You can't use SRCS.INET here?

sys/modules/si/Makefile
9 ↗(On Diff #3187)

Seems like we should be making use of SRCS.DEV_ISA and SRCS.DEV_PCI as well?

imp updated this revision to Diff 3842.

Closed by commit rS278958 (authored by @imp).