Page MenuHomeFreeBSD

net/ipxe: build undionly and efi images
ClosedPublic

Authored by fabian.freyer_physik.tu-berlin.de on Apr 25 2018, 12:40 PM.

Details

Summary

This patch adds default-on options to:

  • build a PXE-bootable image containing only the UNDI driver (undionly.kpxe)
  • build EFI images for i386 and x86_64
Test Plan
  • built using poudriere testport
  • checked EFI images using bhyve(8)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

tobik requested changes to this revision.Apr 25 2018, 1:08 PM
tobik added inline comments.
net/ipxe/Makefile
85

Options description should form their own block, so please move EFI_DESC to the options description block i.e. before ISO_DESC

The other EFI_* options helper need to be moved before the ISO_* options helpers. Keep them sorted.

92

Please remove UNDIONLY . I see no reason why this has to be an option. We can just always build it.

The new images also need to be mentioned in the pkg-message.

99

This needs to be after pre-build-ISO-on

101

cd ${WRKSRC} && ${DO_MAKE_BUILD} => ${DO_MAKE_BUILD} -C ${WRKSRC}

104

... and this after do-install

106

cd ${WRKSRC} is pointless here. Make it part of the INSTALL_DATA command

This revision now requires changes to proceed.Apr 25 2018, 1:08 PM
net/ipxe/Makefile
101

bin-x86_64-efi/ipxe.efi fails to build on i386, so I think we need to either not build the EFI images on i386 via OPTIONS_EXCLUDE_i386=EFI or restrict ourselves to only build bin-i386-efi/ipxe.efi on i386

libgcc/__divdi3.c:1:0: sorry, unimplemented: 64-bit mode not compiled in
 /*
 
libgcc/icc.c:1:0: sorry, unimplemented: 64-bit mode not compiled in
 /*
fabian.freyer_physik.tu-berlin.de marked 6 inline comments as done.

Adressed some comments.

Unfortunately I'm not completely sure how to conditionally include the EFI image filenames in pkg-message.in when the option is set.

net/ipxe/Makefile
92

I'm not sure how to best do this conditionally.

101

I just took this from the default do-build target in bsd.port.mk. Changed it now though.

tobik added inline comments.
net/ipxe/Makefile
92

Always having them in the pkg-message is fine with me. No point in making this more complicated.

This revision is now accepted and ready to land.Apr 25 2018, 3:12 PM
This revision was automatically updated to reflect the committed changes.