Page MenuHomeFreeBSD

devel/py-colorama: Update to 0.3.9 and take maintainership
ClosedPublic

Authored by ygy on Mar 26 2018, 10:31 AM.

Details

Summary
- Update devel/py-colorama to 0.3.9
- Take maintainership

PR: 224169
Approved by: woodsb02
Differential_Revision: https://reviews.freebsd.org/DXXXXX
Test Plan

testport: OK (11.1-RELEASE amd64, 10.4-RELEASE i386)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hi Guangyuan,

You haven't specifically stated that you have also tested the ports which depend on this port - which is always important.

I have tested these continue to build successfully using the following command:
poudriere bulk -t -j 12amd64 devel/awscli devel/py-mondrian devel/py-pinocchio misc/py-socli misc/thefuck net-mgmt/py-ciscoconfparse sysutils/docker-compose sysutils/py-tmuxp www/qutebrowser

I have also performed some runtime testing of this updated version of devel/py-colorama, by testing that misc/thefuck continues to correctly display coloured text in my terminal.

Given this testing, this change appears ok. Please go ahead and commit.

This revision is now accepted and ready to land.Mar 26 2018, 2:54 PM

I also note that it has been more than 3 months since the original PR was submitted, which is sufficient maintainer timeout to take the maintainership.

Hi @woodsb02, thanks! I noted your suggestions and will learn from it. I will also add the maintainer timeout info to the commit message.

This revision was automatically updated to reflect the committed changes.