Page MenuHomeFreeBSD

Correctly mark last section header in El Torito catalog
ClosedPublic

Authored by benno on Mar 23 2018, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 5, 4:50 AM
Unknown Object (File)
Dec 19 2022, 8:58 AM
Unknown Object (File)
Dec 19 2022, 8:51 AM
Unknown Object (File)
Dec 19 2022, 8:47 AM
Unknown Object (File)
Dec 11 2022, 7:26 AM
Subscribers
None

Details

Summary

The final section header in the El Torito catalog should be marked as such. We had a comment saying we'd do that but we weren't.

Test Plan

Test-booted ISO image under both UEFI and BIOS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Does what it says...

Warner

This revision is now accepted and ready to land.Mar 23 2018, 9:36 PM

Worth comparing with NetBSD's?

NetBSD seem to attempt this but it looks like they're actually modifying the last ET_ENTRY_SE entry, not ET_ENTRY_SH. I'm not sure how correct that is.

This revision was automatically updated to reflect the committed changes.