Page MenuHomeFreeBSD
Differential D14812

Correctly mark last section header in El Torito catalog
ClosedPublic
Actions

Authored by benno on Mar 23 2018, 9:31 PM.
Tags
None
Referenced Files
F151823278: D14812.diff
Fri, Apr 10, 10:03 PM
Unknown Object (File)
Sat, Mar 28, 1:26 AM
Unknown Object (File)
Fri, Mar 27, 6:17 PM
Unknown Object (File)
Thu, Mar 26, 6:03 AM
Unknown Object (File)
Thu, Mar 26, 3:14 AM
Unknown Object (File)
Sat, Mar 21, 6:08 PM
Unknown Object (File)
Fri, Mar 13, 5:12 AM
Unknown Object (File)
Feb 26 2026, 1:58 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
imp
Commits
rS331467: Correctly mark the last El Torito section header.
Summary

The final section header in the El Torito catalog should be marked as such. We had a comment saying we'd do that but we weren't.

Test Plan

Test-booted ISO image under both UEFI and BIOS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benno created this revision.Mar 23 2018, 9:31 PM
Harbormaster completed remote builds in B15749: Diff 40655.Mar 23 2018, 9:31 PM
imp accepted this revision.Mar 23 2018, 9:36 PM

Does what it says...

Warner

This revision is now accepted and ready to land.Mar 23 2018, 9:36 PM
emaste added a comment.Mar 23 2018, 9:39 PM

Worth comparing with NetBSD's?

benno added a comment.Mar 23 2018, 9:44 PM

NetBSD seem to attempt this but it looks like they're actually modifying the last ET_ENTRY_SE entry, not ET_ENTRY_SH. I'm not sure how correct that is.

Closed by commit rS331467: Correctly mark the last El Torito section header. (authored by benno). · Explain WhyMar 23 2018, 10:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
makefs/
cd9660/
12 lines

Diff 40658

View Options

head/usr.sbin/makefs/cd9660/cd9660_eltorito.c

Loading...