Page MenuHomeFreeBSD

UEFI Loader: Ditch console mode setting, choose optimal GOP mode later in boot
ClosedPublic

Authored by kevans on Mar 21 2018, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 28 2024, 2:54 AM
Unknown Object (File)
Sep 22 2024, 4:20 PM
Unknown Object (File)
Sep 21 2024, 11:56 AM
Unknown Object (File)
Sep 20 2024, 8:36 AM
Unknown Object (File)
Sep 9 2024, 1:06 AM
Unknown Object (File)
Sep 7 2024, 9:47 PM
Unknown Object (File)
Sep 7 2024, 10:15 AM
Unknown Object (File)
Sep 6 2024, 12:38 PM
Subscribers

Details

Summary

[Successor to D14769]

boot1 is too early to be decided a good resolution. Console modes don't map cleanly/predictably to actual screen resolutions, and GOP does not reflect the actual screen resolution after a console mode change. Rip it out.

Add an efi-autoresize command to loader to choose an optimal screen resolution based on the current environment. We'll explicitly execute this later, preferably before we draw anything of value but after we load config and pick up any tunables we may need to decide where we're going.

This method also allows us to actually pass the correct framebuffer information on to the kernel.

UGA autoresizing is not implemented because it doesn't have the kind of mode enumeration that GOP does. I would like to get my hands on someone with one of these devices and see if UGA actually reflects the current screen resolution after the console mode change- if so, UGA autoresizing will just pick the best console mode that results in the right screen resolution (as reported by UGA).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu added inline comments.
stand/efi/loader/framebuffer.c
505 ↗(On Diff #40562)

efi-autoresize isn't really explicit I think

This isn't completely unreasonable

This revision is now accepted and ready to land.Mar 21 2018, 7:29 PM
This revision was automatically updated to reflect the committed changes.